summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2014-06-06 15:42:42 -0400
committerRich Felker <dalias@aerifal.cx>2014-06-06 15:42:42 -0400
commit7765706c0584ed4a30e0b7a3ada742e490ef02b0 (patch)
tree786ba57bf840d5f5db48167284c55f9db6698e6e /src
parent1cacc01dc0623ac6443e19580222331812bddbbc (diff)
downloadmusl-7765706c0584ed4a30e0b7a3ada742e490ef02b0.tar.gz
add O_CLOEXEC fallback for open and related functions
since there is no easy way to detect whether open honored or ignored the O_CLOEXEC flag, the optimal solution to providing a fallback is simply to make the fcntl syscall to set the close-on-exec flag immediately after open returns.
Diffstat (limited to 'src')
-rw-r--r--src/fcntl/open.c7
-rw-r--r--src/stdio/__fopen_rb_ca.c1
-rw-r--r--src/stdio/fopen.c2
3 files changed, 9 insertions, 1 deletions
diff --git a/src/fcntl/open.c b/src/fcntl/open.c
index 0594ed7e..088a28f7 100644
--- a/src/fcntl/open.c
+++ b/src/fcntl/open.c
@@ -10,7 +10,12 @@ int open(const char *filename, int flags, ...)
va_start(ap, flags);
mode = va_arg(ap, mode_t);
va_end(ap);
- return sys_open_cp(filename, flags, mode);
+
+ int fd = __sys_open_cp(filename, flags, mode);
+ if (fd>=0 && (flags & O_CLOEXEC))
+ __syscall(SYS_fcntl, fd, F_SETFD, FD_CLOEXEC);
+
+ return __syscall_ret(fd);
}
LFS64(open);
diff --git a/src/stdio/__fopen_rb_ca.c b/src/stdio/__fopen_rb_ca.c
index b72c6304..183a5d55 100644
--- a/src/stdio/__fopen_rb_ca.c
+++ b/src/stdio/__fopen_rb_ca.c
@@ -8,6 +8,7 @@ FILE *__fopen_rb_ca(const char *filename, FILE *f, unsigned char *buf, size_t le
f->fd = sys_open(filename, O_RDONLY|O_CLOEXEC);
if (f->fd < 0) return 0;
+ __syscall(SYS_fcntl, f->fd, F_SETFD, FD_CLOEXEC);
f->flags = F_NOWR | F_PERM;
f->buf = buf + UNGET;
diff --git a/src/stdio/fopen.c b/src/stdio/fopen.c
index 3d97cfa8..07bdb6e8 100644
--- a/src/stdio/fopen.c
+++ b/src/stdio/fopen.c
@@ -20,6 +20,8 @@ FILE *fopen(const char *restrict filename, const char *restrict mode)
fd = sys_open_cp(filename, flags, 0666);
if (fd < 0) return 0;
+ if (flags & O_CLOEXEC)
+ __syscall(SYS_fcntl, fd, F_SETFD, FD_CLOEXEC);
f = __fdopen(fd, mode);
if (f) return f;