path: root/src/thread/pthread_setschedprio.c
diff options
authorRich Felker <>2018-05-04 14:26:31 -0400
committerRich Felker <>2018-05-05 11:09:51 -0400
commit526e64f54d729947b35fd39129bc86cbc0b5f098 (patch)
treed13eff2e89069dadfff5ea537c56f422847f8def /src/thread/pthread_setschedprio.c
parent4df42163511182bfd6fc55e85250b93786dcce7e (diff)
improve pthread_exit synchronization with functions targeting tid
if the last thread exited via pthread_exit, the logic that marked it dead did not account for the possibility of it targeting itself via atexit handlers. for example, an atexit handler calling pthread_kill(pthread_self(), SIGKILL) would return success (previously, ESRCH) rather than causing termination via the signal. move the release of killlock after the determination is made whether the exiting thread is the last thread. in the case where it's not, move the release all the way to the end of the function. this way we can clear the tid rather than spending storage on a dedicated dead-flag. clearing the tid is also preferable in that it hardens against inadvertent use of the value after the thread has terminated but before it is joined.
Diffstat (limited to 'src/thread/pthread_setschedprio.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/thread/pthread_setschedprio.c b/src/thread/pthread_setschedprio.c
index dc745b42..c353f6b5 100644
--- a/src/thread/pthread_setschedprio.c
+++ b/src/thread/pthread_setschedprio.c
@@ -4,7 +4,7 @@ int pthread_setschedprio(pthread_t t, int prio)
int r;
- r = t->dead ? ESRCH : -__syscall(SYS_sched_setparam, t->tid, &prio);
+ r = !t->tid ? ESRCH : -__syscall(SYS_sched_setparam, t->tid, &prio);
return r;