path: root/src/thread/mips
diff options
authorRich Felker <>2015-04-14 11:18:59 -0400
committerRich Felker <>2015-04-14 11:18:59 -0400
commitcbc02ba23cec16d7a821648ea8424546bc7f02dc (patch)
treec3650ae9dc0fe3506365371cb0fd0358df6597cf /src/thread/mips
parentbc081f628b51337b525ca2d53aeff1b971f092f5 (diff)
consistently use hidden visibility for cancellable syscall internals
in a few places, non-hidden symbols were referenced from asm in ways that assumed ld-time binding. while these is no semantic reason these symbols need to be hidden, fixing the references without making them hidden was going to be ugly, and hidden reduces some bloat anyway. in the asm files, .global/.hidden directives have been moved to the top to unclutter the actual code.
Diffstat (limited to 'src/thread/mips')
1 files changed, 8 insertions, 3 deletions
diff --git a/src/thread/mips/syscall_cp.s b/src/thread/mips/syscall_cp.s
index d903794d..399289e3 100644
--- a/src/thread/mips/syscall_cp.s
+++ b/src/thread/mips/syscall_cp.s
@@ -1,10 +1,17 @@
.set noreorder __cp_begin
+.hidden __cp_begin __cp_end
+.hidden __cp_end __cp_cancel
+.hidden __cp_cancel
+.hidden __cancel
.global __syscall_cp_asm
+.hidden __syscall_cp_asm
.type __syscall_cp_asm,@function
subu $sp, $sp, 32 __cp_begin
lw $4, 0($4)
bne $4, $0, __cp_cancel
@@ -22,7 +29,6 @@ __cp_begin:
sw $2, 28($sp)
lw $2, 28($sp)
syscall __cp_end
beq $7, $0, 1f
addu $sp, $sp, 32
@@ -30,7 +36,6 @@ __cp_end:
1: jr $ra
nop __cp_cancel
addu $sp, $sp, 32
lw $25, %call16(__cancel)($gp)