path: root/src/thread/cnd_broadcast.c
diff options
authorRich Felker <>2018-09-07 16:20:39 -0400
committerRich Felker <>2018-09-12 14:34:29 -0400
commit60056a8010c3dbaabd713f7a3e4f2963bb921a1b (patch)
treea78579a799af861818ab9831beb945ddfd8970bd /src/thread/cnd_broadcast.c
parentc98bf5b8691b21373ff8d9698e89a75acdefdc75 (diff)
for c11 mtx and cnd functions, use externally consistent type names
despite looking like undefined behavior, the affected code is correct both before and after this patch. the pairs mtx_t and pthread_mutex_t, and cnd_t and pthread_cond_t, are not mutually compatible within a single translation unit (because they are distinct untagged aggregate instances), but they are compatible with an object of either type from another translation unit (6.2.7 ΒΆ1), and therefore a given translation unit can choose which one it wants to use. in the interest of being able to move declarations out of source files to headers that facilitate checking, use the pthread type names in declaring the namespace-safe versions of the pthread functions and cast the argument pointer types when calling them.
Diffstat (limited to 'src/thread/cnd_broadcast.c')
1 files changed, 3 insertions, 2 deletions
diff --git a/src/thread/cnd_broadcast.c b/src/thread/cnd_broadcast.c
index 85d4d3ea..0ad061a3 100644
--- a/src/thread/cnd_broadcast.c
+++ b/src/thread/cnd_broadcast.c
@@ -1,10 +1,11 @@
#include <threads.h>
+#include <pthread.h>
-int __private_cond_signal(cnd_t *, int);
+int __private_cond_signal(pthread_cond_t *, int);
int cnd_broadcast(cnd_t *c)
/* This internal function never fails, and always returns zero,
* which matches the value thrd_success is defined with. */
- return __private_cond_signal(c, -1);
+ return __private_cond_signal((pthread_cond_t *)c, -1);