diff options
| author | Szabolcs Nagy <nsz@port70.net> | 2020-01-20 20:38:45 +0000 |
|---|---|---|
| committer | Rich Felker <dalias@aerifal.cx> | 2020-02-21 23:42:12 -0500 |
| commit | d20558148d8a2c52229b02668627697e83ca3840 (patch) | |
| tree | e4f3373bb8649db621bfeb871ed335e13886b343 /src/math/__expo2f.c | |
| parent | b3797d3b2e10e6fff2a6b04af917e61e95838b08 (diff) | |
| download | musl-d20558148d8a2c52229b02668627697e83ca3840.tar.gz | |
math: fix sinh overflows in non-nearest rounding
The final rounding operation should be done with the correct sign
otherwise huge results may incorrectly get rounded to or away from
infinity in upward or downward rounding modes.
This affected sinh and sinhf which set the sign on the result after
a potentially overflowing mul. There may be other non-nearest rounding
issues, but this was a known long standing issue with large ulp error
(depending on how ulp is defined near infinity).
The fix should have no effect on sinh and sinhf performance but may
have a tiny effect on cosh and coshf.
Diffstat (limited to 'src/math/__expo2f.c')
| -rw-r--r-- | src/math/__expo2f.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/math/__expo2f.c b/src/math/__expo2f.c index 5163e418..538eb09c 100644 --- a/src/math/__expo2f.c +++ b/src/math/__expo2f.c @@ -5,12 +5,13 @@ static const int k = 235; static const float kln2 = 0x1.45c778p+7f; /* expf(x)/2 for x >= log(FLT_MAX), slightly better than 0.5f*expf(x/2)*expf(x/2) */ -float __expo2f(float x) +float __expo2f(float x, float sign) { float scale; /* note that k is odd and scale*scale overflows */ SET_FLOAT_WORD(scale, (uint32_t)(0x7f + k/2) << 23); /* exp(x - k ln2) * 2**(k-1) */ - return expf(x - kln2) * scale * scale; + /* in directed rounding correct sign before rounding or overflow is important */ + return expf(x - kln2) * (sign * scale) * scale; } |