From 59549313d85fa9a0168ff8164cfe734255585f46 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Fri, 11 Jul 2014 00:29:44 -0400 Subject: explicitly reject empty names in dynamic linker load_library function previously passing an empty string for name resulted in failure, as expected, but only after spurious syscalls, and it produced confusing errno values (and thus dlerror strings). in addition to dlopen calls, this issue affected use of LD_PRELOAD with trailing whitespace or colon characters. --- src/ldso/dynlink.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src') diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c index 6b7f0f31..12f14f7b 100644 --- a/src/ldso/dynlink.c +++ b/src/ldso/dynlink.c @@ -663,6 +663,11 @@ static struct dso *load_library(const char *name, struct dso *needed_by) int n_th = 0; int is_self = 0; + if (!*name) { + errno = EINVAL; + return 0; + } + /* Catch and block attempts to reload the implementation itself */ if (name[0]=='l' && name[1]=='i' && name[2]=='b') { static const char *rp, reserved[] = -- cgit v1.2.1