From eca335fc0453d3680fd9f112574919e13fab31d2 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Mon, 6 Jan 2014 22:05:54 -0500 Subject: eliminate explicit (long) casts when making syscalls this practice came from very early, before internal/syscall.h defined macros that could accept pointer arguments directly and handle them correctly. aside from being ugly and unnecessary, it looks like it will be problematic when we add support for 32-bit ABIs on archs where registers (and syscall arguments) are 64-bit, e.g. x32 and mips n32. --- src/time/timer_delete.c | 2 +- src/time/timer_getoverrun.c | 2 +- src/time/timer_gettime.c | 2 +- src/time/timer_settime.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/time') diff --git a/src/time/timer_delete.c b/src/time/timer_delete.c index c81f921a..7c97eeb1 100644 --- a/src/time/timer_delete.c +++ b/src/time/timer_delete.c @@ -10,5 +10,5 @@ int timer_delete(timer_t t) __wake(&td->timer_id, 1, 1); return 0; } - return __syscall(SYS_timer_delete, (long)t); + return __syscall(SYS_timer_delete, t); } diff --git a/src/time/timer_getoverrun.c b/src/time/timer_getoverrun.c index 53361285..e7f891e4 100644 --- a/src/time/timer_getoverrun.c +++ b/src/time/timer_getoverrun.c @@ -8,5 +8,5 @@ int timer_getoverrun(timer_t t) pthread_t td = (void *)((uintptr_t)t << 1); t = (void *)(uintptr_t)(td->timer_id & INT_MAX); } - return syscall(SYS_timer_getoverrun, (long)t); + return syscall(SYS_timer_getoverrun, t); } diff --git a/src/time/timer_gettime.c b/src/time/timer_gettime.c index 1d902075..ed6d8d65 100644 --- a/src/time/timer_gettime.c +++ b/src/time/timer_gettime.c @@ -8,5 +8,5 @@ int timer_gettime(timer_t t, struct itimerspec *val) pthread_t td = (void *)((uintptr_t)t << 1); t = (void *)(uintptr_t)(td->timer_id & INT_MAX); } - return syscall(SYS_timer_gettime, (long)t, val); + return syscall(SYS_timer_gettime, t, val); } diff --git a/src/time/timer_settime.c b/src/time/timer_settime.c index f5f36feb..62631aa4 100644 --- a/src/time/timer_settime.c +++ b/src/time/timer_settime.c @@ -8,5 +8,5 @@ int timer_settime(timer_t t, int flags, const struct itimerspec *restrict val, s pthread_t td = (void *)((uintptr_t)t << 1); t = (void *)(uintptr_t)(td->timer_id & INT_MAX); } - return syscall(SYS_timer_settime, (long)t, flags, val, old); + return syscall(SYS_timer_settime, t, flags, val, old); } -- cgit v1.2.1