From 99b8a25e941e54537bf39ca2f265c345f393f112 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Sat, 7 May 2011 23:23:58 -0400 Subject: overhaul implementation-internal signal protections the new approach relies on the fact that the only ways to create sigset_t objects without invoking UB are to use the sig*set() functions, or from the masks returned by sigprocmask, sigaction, etc. or in the ucontext_t argument to a signal handler. thus, as long as sigfillset and sigaddset avoid adding the "protected" signals, there is no way the application will ever obtain a sigset_t including these bits, and thus no need to add the overhead of checking/clearing them when sigprocmask or sigaction is called. note that the old code actually *failed* to remove the bits from sa_mask when sigaction was called. the new implementations are also significantly smaller, simpler, and faster due to ignoring the useless "GNU HURD signals" 65-1024, which are not used and, if there's any sanity in the world, never will be used. --- src/signal/sigdelset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/signal/sigdelset.c') diff --git a/src/signal/sigdelset.c b/src/signal/sigdelset.c index 14042fb8..f8794ad6 100644 --- a/src/signal/sigdelset.c +++ b/src/signal/sigdelset.c @@ -4,7 +4,7 @@ int sigdelset(sigset_t *set, int sig) { unsigned s = sig-1; - if (s >= 8*sizeof(sigset_t)) { + if (s >= 8*sizeof(sigset_t) || s-32U<3) { errno = EINVAL; return -1; } -- cgit v1.2.1