From 4b87736998e8d8c0610c3c31b6862c77248a98df Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Thu, 29 Sep 2011 00:48:04 -0400 Subject: fix various bugs in path and error handling in execvp/fexecve --- src/process/execvp.c | 42 +++++++++++++++++++++++++----------------- 1 file changed, 25 insertions(+), 17 deletions(-) (limited to 'src/process/execvp.c') diff --git a/src/process/execvp.c b/src/process/execvp.c index d799ddae..b2da44b9 100644 --- a/src/process/execvp.c +++ b/src/process/execvp.c @@ -2,33 +2,41 @@ #include #include #include - -extern char **__environ; +#include int execvp(const char *file, char *const argv[]) { const char *p, *z, *path = getenv("PATH"); - int l; + size_t l, k; + + errno = ENOENT; + if (!*file) return -1; if (strchr(file, '/')) - return execve(file, argv, __environ); + return execv(file, argv); - /* FIXME: integer overflows */ if (!path) path = "/usr/local/bin:/bin:/usr/bin"; - l = strlen(file) + strlen(path) + 2; + k = strnlen(file, NAME_MAX+1); + if (k > NAME_MAX) { + errno = ENAMETOOLONG; + return -1; + } + l = strnlen(path, PATH_MAX-1)+1; - for(p=path; p && *p; p=z) { - char b[l]; + for(p=path; ; p=z) { + char b[l+k+1]; z = strchr(p, ':'); - if (z) { - memcpy(b, p, z-p); - b[z++-p] = 0; - } else strcpy(b, p); - strcat(b, "/"); - strcat(b, file); - if (!access(b, X_OK)) - return execve(b, argv, __environ); + if (!z) z = p+strlen(p); + if (z-p >= l) { + if (!*z++) break; + continue; + } + memcpy(b, p, z-p); + b[z-p] = '/'; + memcpy(b+(z-p)+(z>p), file, k+1); + execv(b, argv); + if (errno != ENOENT) return -1; + if (!*z++) break; } - errno = ENOENT; return -1; } -- cgit v1.2.1