From 2abb70c302efe46dfd8fd9e1d64fa00f1376f428 Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Thu, 5 Jun 2014 22:52:40 +0200 Subject: fix the domain name length limit checks A domain name is at most 255 bytes long (RFC 1035), but the string representation is two bytes smaller so the strlen maximum is 253. --- src/network/res_querydomain.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/network/res_querydomain.c') diff --git a/src/network/res_querydomain.c b/src/network/res_querydomain.c index c746dbe6..8ba31f45 100644 --- a/src/network/res_querydomain.c +++ b/src/network/res_querydomain.c @@ -3,10 +3,10 @@ int res_querydomain(const char *name, const char *domain, int class, int type, unsigned char *dest, int len) { - char tmp[256]; - size_t nl = strnlen(name, 256); - size_t dl = strnlen(domain, 256); - if (nl+dl+1 > 255) return -1; + char tmp[254]; + size_t nl = strnlen(name, 254); + size_t dl = strnlen(domain, 254); + if (nl+dl+1 > 253) return -1; memcpy(tmp, name, nl); tmp[nl] = '.'; memcpy(tmp+nl+1, domain, dl+1); -- cgit v1.2.1