From 2abb70c302efe46dfd8fd9e1d64fa00f1376f428 Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Thu, 5 Jun 2014 22:52:40 +0200 Subject: fix the domain name length limit checks A domain name is at most 255 bytes long (RFC 1035), but the string representation is two bytes smaller so the strlen maximum is 253. --- src/network/res_mkquery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/network/res_mkquery.c') diff --git a/src/network/res_mkquery.c b/src/network/res_mkquery.c index f7e4e9c6..7c49709e 100644 --- a/src/network/res_mkquery.c +++ b/src/network/res_mkquery.c @@ -10,9 +10,9 @@ int __res_mkquery(int op, const char *dname, int class, int type, int id, i, j; unsigned char q[280]; struct timespec ts; - size_t l = strnlen(dname, 256); + size_t l = strnlen(dname, 254); - if (l-1>=254 || buflen<18+l || op>15u || class>255u || type>255u) + if (l-1>=253 || buflen<18+l || op>15u || class>255u || type>255u) return -1; /* Construct query template - ID will be filled later */ -- cgit v1.2.1