From f4d9bfb3a986f2c25ec023426b4fb222130af75f Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Thu, 5 Sep 2013 16:57:46 +0000 Subject: math: fix atanh (overflow and underflow issues) in atanh exception handling was left to the called log functions, but the argument to those functions could underflow or overflow. use double_t and float_t to avoid some useless stores on x86 --- src/math/atanhf.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) (limited to 'src/math/atanhf.c') diff --git a/src/math/atanhf.c b/src/math/atanhf.c index ca106efc..65f07c0f 100644 --- a/src/math/atanhf.c +++ b/src/math/atanhf.c @@ -5,16 +5,24 @@ float atanhf(float x) { union {float f; uint32_t i;} u = {.f = x}; unsigned s = u.i >> 31; + float_t y; /* |x| */ u.i &= 0x7fffffff; - x = u.f; + y = u.f; if (u.i < 0x3f800000 - (1<<23)) { - /* |x| < 0.5, up to 1.7ulp error */ - x = 0.5f*log1pf(2*x + 2*x*x/(1-x)); + if (u.i < 0x3f800000 - (32<<23)) { + /* handle underflow */ + if (u.i < (1<<23)) + FORCE_EVAL((float)(y*y)); + } else { + /* |x| < 0.5, up to 1.7ulp error */ + y = 0.5f*log1pf(2*y + 2*y*y/(1-y)); + } } else { - x = 0.5f*log1pf(2*x/(1-x)); + /* avoid overflow */ + y = 0.5f*log1pf(2*(y/(1-y))); } - return s ? -x : x; + return s ? -y : y; } -- cgit v1.2.1