From 1ae4bc42808111d6b3f50c063de102f162051986 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Sun, 28 Jul 2013 03:41:01 -0400 Subject: fix semantically incorrect use of LC_GLOBAL_LOCALE LC_GLOBAL_LOCALE refers to the global locale, controlled by setlocale, not the thread-local locale in effect which these functions should be using. neither LC_GLOBAL_LOCALE nor 0 has an argument to the *_l functions has behavior defined by the standard, but 0 is a more logical choice for requesting the callee to lookup the current locale. in the future I may move the current locale lookup the the caller (the non-_l-suffixed wrapper). at this point, all of the locale logic is dummied out, so no harm was done, but it should at least avoid misleading usage. --- src/locale/wcscoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/locale/wcscoll.c') diff --git a/src/locale/wcscoll.c b/src/locale/wcscoll.c index 95a4ca74..20a60900 100644 --- a/src/locale/wcscoll.c +++ b/src/locale/wcscoll.c @@ -10,7 +10,7 @@ int __wcscoll_l(const wchar_t *l, const wchar_t *r, locale_t locale) int wcscoll(const wchar_t *l, const wchar_t *r) { - return __wcscoll_l(l, r, LC_GLOBAL_LOCALE); + return __wcscoll_l(l, r, 0); } weak_alias(__wcscoll_l, wcscoll_l); -- cgit v1.2.1