From c221d3e5862e249b03aa7569d5fec6389294fb22 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Thu, 6 Sep 2018 11:15:15 -0400 Subject: fix issues from public functions defined without declaration visible policy is that all public functions which have a public declaration should be defined in a context where that public declaration is visible, to avoid preventable type mismatches. an audit performed using GCC's -Wmissing-declarations turned up the violations corrected here. in some cases the public header had not been included; in others, a feature test macro needed to make the declaration visible had been omitted. in the case of gethostent and getnetent, the omission seems to have been intentional, as a hack to admit a single stub definition for both functions. this kind of hack is no longer acceptable; it's UB and would not fly with LTO or advanced toolchains. the hack is undone to make exposure of the declarations possible. --- src/linux/brk.c | 2 ++ src/linux/clone.c | 2 ++ src/linux/sbrk.c | 2 ++ 3 files changed, 6 insertions(+) (limited to 'src/linux') diff --git a/src/linux/brk.c b/src/linux/brk.c index ffdbbd52..a6173e07 100644 --- a/src/linux/brk.c +++ b/src/linux/brk.c @@ -1,3 +1,5 @@ +#define _BSD_SOURCE +#include #include #include "syscall.h" diff --git a/src/linux/clone.c b/src/linux/clone.c index b9e55945..8c1af7d3 100644 --- a/src/linux/clone.c +++ b/src/linux/clone.c @@ -1,5 +1,7 @@ +#define _GNU_SOURCE #include #include +#include #include "pthread_impl.h" #include "syscall.h" diff --git a/src/linux/sbrk.c b/src/linux/sbrk.c index 1e82d643..bb866305 100644 --- a/src/linux/sbrk.c +++ b/src/linux/sbrk.c @@ -1,3 +1,5 @@ +#define _BSD_SOURCE +#include #include #include #include "syscall.h" -- cgit v1.2.1