summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorLines
2013-10-18in faccessat slow path, add close-on-exec to pipe fdsRich Felker-1/+1
as usual, this is needed to avoid fd leaks. as a better solution, the use of fds could possibly be replaced with mmap and a futex.
2013-10-12fix uid/gid-setting error in faccessat with AT_EACCESS flagRich Felker-2/+2
this fixes an issue reported by Daniel Thau whereby faccessat with the AT_EACCESS flag did not work in cases where the process is running suid or sgid but without root privileges. per POSIX, when the process does not have "appropriate privileges", setuid changes the euid, not the real uid, and the target uid must be equal to the current real or saved uid; if this condition is not met, EPERM results. this caused the faccessat child process to fail. using the setreuid syscall rather than setuid works. POSIX leaves it unspecified whether setreuid can set the real user id to the effective user id on processes without "appropriate privileges", but Linux allows this; if it's not allowed, there would be no way for this function to work.
2013-10-08fix errno value for getcwd when size argument is zeroRich Felker-1/+7
based on patch by Michael Forney. at the same time, I've changed the if branch to be more clear, avoiding the comma operator. the underlying issue is that Linux always returns ERANGE when size is too short, even when it's zero, rather than returning EINVAL for the special case of zero as required by POSIX.
2013-10-07math: fix rare underflow issue in fmaSzabolcs Nagy-13/+55
the issue is described in commits 1e5eb73545ca6cfe8b918798835aaf6e07af5beb and ffd8ac2dd50f99c3c83d7d9d845df9874ec3e7d5
2013-10-07math: use sqrtl if FLT_EVAL_METHOD==2 in acosh and acoshfSzabolcs Nagy-0/+13
this makes acosh slightly more precise around 1.0 on i386
2013-10-07remove errno setting from setenv, malloc sets it correctly on oomSzabolcs Nagy-1/+0
2013-10-07fix allocation sizes in regcompSzabolcs Nagy-4/+4
sizeof had incorrect argument in a few places, the size was always large enough so the issue was not critical.
2013-10-07add missing va_end in execl* for correcness and static code analyzersSzabolcs Nagy-0/+3
2013-10-07minor vfprintf and vfwprintf changes to please static code analyzersSzabolcs Nagy-6/+11
add missing va_end and remove some unnecessary code.
2013-10-06math: remove an unused variable from modflSzabolcs Nagy-1/+0
2013-10-05slightly optimize __brk for sizeRich Felker-1/+1
there is no reason to check the return value for setting errno, since brk never returns errors, only the new value of the brk (which may be the same as the old, or otherwise differ from the requested brk, on failure). it may be beneficial to eventually just eliminate this file and make the syscalls inline in malloc.c.
2013-10-05fix failure of malloc to set errno on heap (brk) exhaustionRich Felker-0/+1
I wrongly assumed the brk syscall would set errno, but on failure it returns the old value of the brk rather than an error code.
2013-10-04fix failure to check malloc result in setenvRich Felker-9/+9
2013-10-04math: remove code duplication in erfl found by clang analyzerSzabolcs Nagy-13/+2
erfl had some superflous code left around after the last erf cleanup. the issue was reported by Alexander Monakov
2013-10-04math: remove a useless assignment in lgammal found by clang analyzerSzabolcs Nagy-2/+2
the issue was reported by Alexander Monakov
2013-10-04fix invalid implicit pointer conversion in pthread_key_createRich Felker-1/+1
2013-10-04fix uninitialized variable in dladdrRich Felker-1/+1
the affected branch only applies for DSOs that lack standard hash table and only have the GNU hash table present.
2013-10-04removed unused variable in vfwprintfRich Felker-2/+1
2013-10-03fix new environment always being null with execleRich Felker-2/+1
the va_arg call for the argv[]-terminating null pointer was missing, so this pointer was being wrongly used as the environment pointer. issue reported by Timo Teräs. proposed patch slightly modified to simplify the resulting code.
2013-09-29fix off-by-one error in getgrnam_r and getgrgid_r, clobbering gr_nameRich Felker-2/+2
bug report and patch by Michael Forney. the terminating null pointer at the end of the gr_mem array was overwriting the beginning of the string data, causing the gr_name member to always be a zero-length string.
2013-09-27fix buffer overflow in mbsrtowcsRich Felker-1/+1
issue reported by Michael Forney: "If wn becomes 0 after processing a chunk of 4, mbsrtowcs currently continues on, wrapping wn around to -1, causing the rest of the string to be processed. This resulted in buffer overruns if there was only space in ws for wn wide characters." the original patch submitted added an additional check for !wn after the loop; to avoid extra branching, I instead just changed the wn>=4 check to wn>=5 to ensure that at least one slot remains after the word-at-a-time loop runs. this should not slow down the tail processing on real-world usage, since an extra slot that can't be processed in the word-at-a-time loop is needed for the null termination anyway.
2013-09-20fix potential deadlock bug in libc-internal locking logicRich Felker-13/+15
if a multithreaded program became non-multithreaded (i.e. all other threads exited) while one thread held an internal lock, the remaining thread would fail to release the lock. the the program then became multithreaded again at a later time, any further attempts to obtain the lock would deadlock permanently. the underlying cause is that the value of libc.threads_minus_1 at unlock time might not match the value at lock time. one solution would be returning a flag to the caller indicating whether the lock was taken and needs to be unlocked, but there is a simpler solution: using the lock itself as such a flag. note that this flag is not needed anyway for correctness; if the lock is not held, the unlock code is harmless. however, the memory synchronization properties associated with a_store are costly on some archs, so it's best to avoid executing the unlock code when it is unnecessary.
2013-09-20correct the sysconf value for RTSIG_MAXRich Felker-1/+2
this is the number of realtime signals available, not the maximum signal number or total number of signals.
2013-09-16fix sigemptyset and sigfillset for mipsRich Felker-1/+10
they were leaving junk in the upper bits.
2013-09-16fix clobbering of caller's stack in mips __clone functionRich Felker-0/+3
this was resulting in crashes in posix_spawn on mips, and would have affected applications calling clone too. since the prototype for __clone has it as a variadic function, it may not assume that 16($sp) is writable for use in making the syscall. instead, it needs to allocate additional stack space, and then adjust the stack pointer back in both of the code paths for the parent process/thread.
2013-09-16omit CLONE_PARENT flag to clone in pthread_createRich Felker-1/+1
CLONE_PARENT is not necessary (CLONE_THREAD provides all the useful parts of it) and Linux treats CLONE_PARENT as an error in certain situations, without noticing that it would be a no-op due to CLONE_THREAD. this error case prevents, for example, use of a multi-threaded init process and certain usages with containers.
2013-09-16use symbolic names for clone flags in pthread_createRich Felker-2/+5
2013-09-15support configurable page size on mips, powerpc and microblazeSzabolcs Nagy-11/+24
PAGE_SIZE was hardcoded to 4096, which is historically what most systems use, but on several archs it is a kernel config parameter, user space can only know it at execution time from the aux vector. PAGE_SIZE and PAGESIZE are not defined on archs where page size is a runtime parameter, applications should use sysconf(_SC_PAGE_SIZE) to query it. Internally libc code defines PAGE_SIZE to libc.page_size, which is set to aux[AT_PAGESZ] in __init_libc and early in __dynlink as well. (Note that libc.page_size can be accessed without GOT, ie. before relocations are done) Some fpathconf settings are hardcoded to 4096, these should be actually queried from the filesystem using statfs.
2013-09-14fix overflow in sysconf for _SC_MQ_PRIO_MAXRich Felker-1/+2
the value of MQ_PRIO_MAX does not fit, so it needs to use OFLOW.
2013-09-14fix child stack alignment on mips cloneRich Felker-0/+1
unlike other archs, the mips version of clone was not doing anything to align the stack pointer. this seems to have been the cause for some SIGBUS crashes that were observed in posix_spawn.
2013-09-13fix x86_64 lrintl asm, againRich Felker-2/+2
the underlying problem was not incorrect sign extension (fixed in the previous commit to this file by nsz) but that code that treats "long" as 32-bit was copied blindly from i386 to x86_64. now lrintl is identical to llrintl on x86_64, as it should be.
2013-09-09do not use default when dynamic linker fails to open existing path fileRich Felker-0/+2
if fopen fails for a reason other than ENOENT, we must assume the intent is that the path file be used. failure may be due to misconfiguration or intentional resource-exhaustion attack (against suid programs), in which case falling back to loading libraries from an unintended path could be dangerous.
2013-09-06math: remove STRICT_ASSIGN from exp2f (see previous commit)Szabolcs Nagy-1/+1
2013-09-06math: remove STRICT_ASSIGN macroSzabolcs Nagy-23/+13
gcc did not always drop excess precision according to c99 at assignments before version 4.5 even if -std=c99 was requested which caused badly broken mathematical functions on i386 when FLT_EVAL_METHOD!=0 but STRICT_ASSIGN was not used consistently and it is worked around for old compilers with -ffloat-store so it is no longer needed the new convention is to get the compiler respect c99 semantics and when excess precision is not harmful use float_t or double_t or to specialize code using FLT_EVAL_METHOD
2013-09-05math: support invalid ld80 representations in fpclassifySzabolcs Nagy-2/+4
apparently gnulib requires invalid long double representations to be handled correctly in printf so we classify them according to how the fpu treats them: bad inf is nan, bad nan is nan, bad normal is nan and bad subnormal/zero is minimal normal
2013-09-05math: fix atanh (overflow and underflow issues)Szabolcs Nagy-14/+37
in atanh exception handling was left to the called log functions, but the argument to those functions could underflow or overflow. use double_t and float_t to avoid some useless stores on x86
2013-09-05math: remove libc.h include from libm.hSzabolcs Nagy-3/+5
libc.h is only for weak_alias so include it directly where it is used
2013-09-05math: fix acoshf on negative valuesSzabolcs Nagy-7/+8
acosh(x) is invalid for x<1, acoshf tried to be clever using signed comparisions to handle all x<2 the same way, but the formula was wrong on large negative values.
2013-09-05math: fix expm1l on x86_64 (avoid underflow for large negative x)Szabolcs Nagy-3/+13
copy the fix from i386: return -1 instead of exp2l(x)-1 when x <= -65
2013-09-05math: fix lrintl.s on x86_64 (use movslq to signextend the result)Szabolcs Nagy-1/+1
2013-09-05math: fix exp2l asm on x86 (raise underflow correctly)Szabolcs Nagy-67/+78
there were two problems: * omitted underflow on subnormal results: exp2l(-16383.5) was calculated as sqrt(2)*2^-16384, the last bits of sqrt(2) are zero so the down scaling does not underflow eventhough the result is in subnormal range * spurious underflow for subnormal inputs: exp2l(0x1p-16400) was evaluated as f2xm1(x)+1 and f2xm1 raised underflow (because inexact subnormal result) the first issue is fixed by raising underflow manually if x is in (-32768,-16382] and not integer (x-0x1p63+0x1p63 != x) the second issue is fixed by treating x in (-0x1p64,0x1p64) specially for these fixes the special case handling was completely rewritten
2013-09-05math: cosmetic cleanup (use explicit union instead of fshape and dshape)Szabolcs Nagy-166/+140
2013-09-05math: remove *_WORD64 macros from libm.hSzabolcs Nagy-29/+13
only fma used these macros and the explicit union is clearer
2013-09-05math: remove old longdbl.hSzabolcs Nagy-113/+0
2013-09-05math: long double fix (use ldshape union)Szabolcs Nagy-51/+24
* use new ldshape union consistently * add ld128 support to frexpl * simplify sqrtl comment (ld64 is not just arm)
2013-09-05math: use float_t and double_t in scalbnf and scalbnSzabolcs Nagy-16/+20
remove STRICT_ASSIGN (c99 semantics is assumed) and use the conventional union to prepare the scaling factor (so libm.h is no longer needed)
2013-09-05math: fix remaining old long double code (erfl, fmal, lgammal, scalbnl)Szabolcs Nagy-93/+65
in lgammal don't handle 1 and 2 specially, in fma use the new ldshape union instead of ld80 one.
2013-09-05math: cbrt cleanup and long double fixSzabolcs Nagy-72/+59
* use float_t and double_t * cleanup subnormal handling * bithacks according to the new convention (ldshape for long double and explicit unions for float and double)
2013-09-05math: fix underflow in exp*.c and long double handling in exp2lSzabolcs Nagy-182/+139
* don't care about inexact flag * use double_t and float_t (faster, smaller, more precise on x86) * exp: underflow when result is zero or subnormal and not -inf * exp2: underflow when result is zero or subnormal and not exact * expm1: underflow when result is zero or subnormal * expl: don't underflow on -inf * exp2: fix incorrect comment * expm1: simplify special case handling and overflow properly * expm1: cleanup final scaling and fix negative left shift ub (twopk)
2013-09-05math: long double trigonometric cleanup (cosl, sinl, sincosl, tanl)Szabolcs Nagy-236/+228
ld128 support was added to internal kernel functions (__cosl, __sinl, __tanl, __rem_pio2l) from freebsd (not tested, but should be a good start for when ld128 arch arrives) __rem_pio2l had some code cleanup, the freebsd ld128 code seems to gather the results of a large reduction with precision loss (fixed the bug but a todo comment was added for later investigation) the old copyright was removed from the non-kernel wrapper functions (cosl, sinl, sincosl, tanl) since these are trivial and the interesting parts and comments had been already rewritten.