summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorLines
2018-09-12apply hidden visibility to pthread internalsRich Felker-11/+11
2018-09-12apply hidden visibility to stdio internalsRich Felker-26/+26
2018-09-12apply hidden visibility to internal time[zone] implementation functionsRich Felker-8/+8
2018-09-12apply hidden visibility to internal math functionsRich Felker-26/+26
this makes significant differences to codegen on archs with an expensive PLT-calling ABI; on i386 and gcc 7.3 for example, the sin and sinf functions no longer touch call-saved registers or the stack except for pushing outgoing arguments. performance is likely improved too, but no measurements were taken.
2018-09-12overhaul internally-public declarations using wrapper headersRich Felker-189/+199
commits leading up to this one have moved the vast majority of libc-internal interface declarations to appropriate internal headers, allowing them to be type-checked and setting the stage to limit their visibility. the ones that have not yet been moved are mostly namespace-protected aliases for standard/public interfaces, which exist to facilitate implementing plain C functions in terms of POSIX functionality, or C or POSIX functionality in terms of extensions that are not standardized. some don't quite fit this description, but are "internally public" interfacs between subsystems of libc. rather than create a number of newly-named headers to declare these functions, and having to add explicit include directives for them to every source file where they're needed, I have introduced a method of wrapping the corresponding public headers. parallel to the public headers in $(srcdir)/include, we now have wrappers in $(srcdir)/src/include that come earlier in the include path order. they include the public header they're wrapping, then add declarations for namespace-protected versions of the same interfaces and any "internally public" interfaces for the subsystem they correspond to. along these lines, the wrapper for features.h is now responsible for the definition of the hidden, weak, and weak_alias macros. this means source files will no longer need to include any special headers to access these features. over time, it is my expectation that the scope of what is "internally public" will expand, reducing the number of source files which need to include *_impl.h and related headers down to those which are actually implementing the corresponding subsystems, not just using them.
2018-09-12declare __getopt_msg in stdio_impl.hRich Felker-2/+3
it's not ideal, but the function is essentially an extended stdio function specialized to getopt's needs. the only reason it exists is avoiding pulling printf code into every program using getopt.
2018-09-12use lighter internal stdio lock in getopt error printingRich Felker-2/+3
the public flockfile interface is significantly heavier because it has to handle the possibility of caller returning or thread exiting while holding the lock.
2018-09-12add crypt_des header for declarations shared with encrypt functionRich Felker-12/+16
2018-09-12make mkostemps source file include the header for its declarationRich Felker-0/+1
2018-09-12move __memalign declaration to malloc_impl.hRich Felker-4/+4
the malloc-implementation-private header is the only right place for this, because, being in the reserved namespace, __memalign is not interposable and thus not valid to use anywhere else. anything outside of the malloc implementation must call an appropriate-namespace public function (aligned_alloc or posix_memalign).
2018-09-12use hidden visibility for sh __unmapself backendsRich Felker-2/+3
2018-09-12rework mechanism for posix_spawnp calling posix_spawnRich Felker-19/+9
previously, a common __posix_spawnx backend was used that accepted an additional argument for the execve variant to call in the child. this moderately bloated up the posix_spawn function, shuffling arguments between stack and/or registers to call a 7-argument function from a 6-argument one. instead, tuck the exec function pointer in an unused part of the (large) pthread_spawnattr_t structure, and have posix_spawnp duplicate the attributes and fill in a pointer to __execvpe. the net code size change is minimal, but the weight is shifted to the "heavier" function which already pulls in more dependencies. as a bonus, we get rid of an external symbol (__posix_spawnx) that had no really good place for a declaration because it shouldn't have existed to begin with.
2018-09-12make arch __fesetround backends hiddenRich Felker-4/+18
these are not public interfaces and do not match the public function, but delegate argument checking to it.
2018-09-12make arch __set_thread_area backends hiddenRich Felker-1/+10
this is not a public interface, and does not even necessarily match the syscall on all archs that have a syscall by that name. on archs where it's implemented in C, no action on the source file is needed; the hidden declaration in pthread_arch.h suffices.
2018-09-12make arch __clone backends hiddenRich Felker-1/+16
these are not a public interface and are not intended to be callable from anywhere but the public clone function or other places in libc.
2018-09-12move tlsdesc and internal dl function declarations to dynlink.hRich Felker-16/+17
2018-09-12add internal header for declaring __pleval function (used by gettext)Rich Felker-1/+8
locale_impl.h could have been used, but this function is completely independent of anything else, and preserving that property seems nice.
2018-09-12move __stdio_exit_needed to stdio_impl.hRich Felker-4/+2
this functions is glue for linking dependency logic.
2018-09-12move __loc_is_allocated declaration to locale_impl.hRich Felker-2/+1
2018-09-12move declarations of tls setup/access functions to pthread_impl.hRich Felker-6/+6
it's already included in all places where these are needed, and aside from __tls_get_addr, they're all implementation internals.
2018-09-12add and use internal header for *rand48 lcgRich Felker-13/+12
2018-09-12move __strftime_fmt_1 declaration to time_impl.hRich Felker-2/+2
this is a helper function from strftime that's also used by wcsftime.
2018-09-12move __tm_to_tzname declaration to time_impl.h with related functionsRich Felker-1/+1
this function was added later for strftime use and the existence of time_impl.h as the appropriate place for it seems to have been overlooked.
2018-09-12remove unused code from strcpy.cRich Felker-7/+0
2018-09-12move __res_msend_rc declaration to lookup.hRich Felker-1/+1
unlike the other res/dn functions, this one is tied to struct resolvconf which is not a public interface, so put it in the private header for its subsystem.
2018-09-12fix type-mismatched declarations of __nl_langinfo_l in source filesRich Felker-2/+2
obviously the type "should be" const, but it inherited non-const from the standard nl_langinfo_l.
2018-09-12for c11 mtx and cnd functions, use externally consistent type namesRich Felker-12/+17
despite looking like undefined behavior, the affected code is correct both before and after this patch. the pairs mtx_t and pthread_mutex_t, and cnd_t and pthread_cond_t, are not mutually compatible within a single translation unit (because they are distinct untagged aggregate instances), but they are compatible with an object of either type from another translation unit (6.2.7 ΒΆ1), and therefore a given translation unit can choose which one it wants to use. in the interest of being able to move declarations out of source files to headers that facilitate checking, use the pthread type names in declaring the namespace-safe versions of the pthread functions and cast the argument pointer types when calling them.
2018-09-12move and deduplicate declarations of __dns_parse to make it checkableRich Felker-2/+3
the source file for this function is completely standalone, but it doesn't seem worth adding a header just for it, so declare it in lookup.h for now.
2018-09-12move lgamma-related internal declarations to libm.hRich Felker-12/+7
2018-09-12declare __syscall_ret as hidden in vfork asmRich Felker-0/+4
without this, it's plausible that assembler or linker could complain about an unsatisfiable relocation.
2018-09-12add arm asm for vforkPatrick Oppenlander-0/+13
2018-09-12move declarations for malloc internals to malloc_impl.hRich Felker-6/+6
2018-09-12improve machinery for ldso to report libc versionRich Felker-6/+3
eliminate gratuitous glue function for reporting the version, which was probably leftover from the old dynamic linker design which lacked a clear barrier for when/how it could access global data. put the declaration for the data object that replaces it in libc.h where it can be type checked.
2018-09-12make internal declarations for flockfile tracking functions checkableRich Felker-4/+5
logically these belong to the intersection of the stdio and pthread subsystems, and either place the declarations could go (stdio_impl.h or pthread_impl.h) requires a forward declaration for one of the argument types.
2018-09-12make inadvertently exposed __h{create,delete,search}_r functions staticRich Felker-6/+6
2018-09-12make inadvertently exposed __pthread_{timed,try}join_np functions staticRich Felker-2/+2
these exist for the sake of defining the corresponding weak public aliases (for C11 and POSIX namespace conformance reasons). they are not referenced by anything else in libc, so make them static.
2018-09-12use idiomatic weak alias approach for defining asctime_rRich Felker-33/+28
get rid of a gratuitous translation unit and call frame between asctime_r and the actual implementation of the function. this is the way gmtime_r and localtime_r are already done.
2018-09-12move and deduplicate declarations of __vdsosym to make it checkableRich Felker-4/+2
2018-09-12move and deduplicate declarations of __procfdname to make it checkableRich Felker-16/+5
syscall.h was chosen as the header to declare it, since its intended usage is alongside syscalls as a fallback for operations the direct syscall does not support.
2018-09-12fix issues from public functions defined without declaration visibleRich Felker-2/+22
policy is that all public functions which have a public declaration should be defined in a context where that public declaration is visible, to avoid preventable type mismatches. an audit performed using GCC's -Wmissing-declarations turned up the violations corrected here. in some cases the public header had not been included; in others, a feature test macro needed to make the declaration visible had been omitted. in the case of gethostent and getnetent, the omission seems to have been intentional, as a hack to admit a single stub definition for both functions. this kind of hack is no longer acceptable; it's UB and would not fly with LTO or advanced toolchains. the hack is undone to make exposure of the declarations possible.
2018-09-05remove leftover declarations for removed functions from pthread_impl.hRich Felker-4/+0
2018-09-05define and use internal macros for hidden visibility, weak refsRich Felker-88/+66
this cleans up what had become widespread direct inline use of "GNU C" style attributes directly in the source, and lowers the barrier to increased use of hidden visibility, which will be useful to recovering some of the efficiency lost when the protected visibility hack was dropped in commit dc2f368e565c37728b0d620380b849c3a1ddd78f, especially on archs where the PLT ABI is costly.
2018-09-04fix namespace violation for c11 mutex functionsRich Felker-1/+3
__pthread_mutex_timedlock is used to implement c11 mutex functions, and therefore cannot call pthread_mutex_trylock by name.
2018-09-04in pthread_mutex_timedlock, avoid repeatedly reading mutex type fieldRich Felker-3/+4
compiler cannot cache immutable fields of the mutex object across external calls it can't see, much less across atomics.
2018-09-04in pthread_mutex_trylock, EBUSY out more directly when possibleRich Felker-2/+2
avoid gratuitously setting up and tearing down the robust list pending slot.
2018-09-04implement fexecve in terms of execveat when it existsJoseph C. Sible-0/+5
This lets fexecve work even when /proc isn't mounted.
2018-09-02fix stack-based oob memory clobber in resolver's result sortingRich Felker-1/+1
commit 4f35eb7591031a1e5ef9828f9304361f282f28b9 introduced this bug. it is not present in any released versions. inadvertent use of the & operator on an array into which we're indexing produced arithmetic on the wrong-type pointer, with undefined behavior.
2018-09-01consistently use _NSIG/8 idiom for kernel sigset size in sigactionRich Felker-3/+3
this code in sigaction was the only place where sizeof was being applied to the kernel sigaction's mask member to get the size argument to pass to the kernel. everywhere else, _NSIG/8 is used for this purpose.
2018-09-01always terminate by SIGABRT when abort is calledRich Felker-4/+40
Linux makes this surprisingly difficult, but it can be done. the trick here is using the fact that we control the implementation of sigaction to prevent changing the disposition of SIGABRT to anything but SIG_DFL after abort has tried and failed to terminate the process simply by calling raise(SIGABRT).
2018-09-01optimize raise not to make a syscall for getting tidRich Felker-3/+1
assuming signals are blocked, which they are here, the tid in the thread structure is always valid and cannot change out from under us.