summaryrefslogtreecommitdiff
path: root/src/thread
AgeCommit message (Collapse)AuthorLines
2011-04-17overhaul pthread cancellationRich Felker-59/+182
this patch improves the correctness, simplicity, and size of cancellation-related code. modulo any small errors, it should now be completely conformant, safe, and resource-leak free. the notion of entering and exiting cancellation-point context has been completely eliminated and replaced with alternative syscall assembly code for cancellable syscalls. the assembly is responsible for setting up execution context information (stack pointer and address of the syscall instruction) which the cancellation signal handler can use to determine whether the interrupted code was in a cancellable state. these changes eliminate race conditions in the previous generation of cancellation handling code (whereby a cancellation request received just prior to the syscall would not be processed, leaving the syscall to block, potentially indefinitely), and remedy an issue where non-cancellable syscalls made from signal handlers became cancellable if the signal handler interrupted a cancellation point. x86_64 asm is untested and may need a second try to get it right.
2011-04-14change sem_trywait algorithm so it never has to call __wakeRich Felker-3/+2
2011-04-14cheap trick to further optimize locking normal mutexesRich Felker-2/+2
2011-04-14use a separate signal from SIGCANCEL for SIGEV_THREAD timersRich Felker-2/+0
otherwise we cannot support an application's desire to use asynchronous cancellation within the callback function. this change also slightly debloats pthread_create.c.
2011-04-13simplify cancellation point handlingRich Felker-16/+5
we take advantage of the fact that unless self->cancelpt is 1, cancellation cannot happen. so just increment it by 2 to temporarily block cancellation. this drops pthread_create.o well under 1k.
2011-04-06fixed crash in new rsyscall (failure to set sa_flags for signal handler)Rich Felker-0/+2
2011-04-06consistency: change all remaining syscalls to use SYS_ rather than __NR_ prefixRich Felker-8/+8
2011-04-06move rsyscall out of pthread_create moduleRich Felker-96/+122
this is something of a tradeoff, as now set*id() functions, rather than pthread_create, are what pull in the code overhead for dealing with linux's refusal to implement proper POSIX thread-vs-process semantics. my motivations are: 1. it's cleaner this way, especially cleaner to optimize out the rsyscall locking overhead from pthread_create when it's not needed. 2. it's expected that only a tiny number of core system programs will ever use set*id() functions, whereas many programs may want to use threads, and making thread overhead tiny is an incentive for "light" programs to try threads.
2011-04-06pthread exit stuff: don't bother setting errno when we won't check it.Rich Felker-2/+2
2011-04-06fix rsyscall handler: must not clobber errno from signal contextRich Felker-2/+4
2011-04-06major semaphore improvements (performance and correctness)Rich Felker-21/+37
1. make sem_[timed]wait interruptible by signals, per POSIX 2. keep a waiter count in order to avoid unnecessary futex wake syscalls
2011-04-05new framework to inhibit thread cancellation when neededRich Felker-5/+15
with these small changes, libc functions which need to call functions which are cancellation points, but which themselves must not be cancellation points, can use the CANCELPT_INHIBIT and CANCELPT_RESUME macros to temporarily inhibit all cancellation.
2011-04-03pthread_create need not set errnoRich Felker-1/+1
2011-04-03block all signals during rsyscallRich Felker-4/+9
otherwise a signal handler could see an inconsistent and nonconformant program state where different threads have different uids/gids.
2011-04-03fix race condition in rsyscall handlerRich Felker-1/+1
the problem: there is a (single-instruction) race condition window between a thread flagging itself dead and decrementing itself from the thread count. if it receives the rsyscall signal at this exact moment, the rsyscall caller will never succeed in signalling enough flags to succeed, and will deadlock forever. in previous versions of musl, the about-to-terminate thread masked all signals prior to decrementing the thread count, but this cost a whole syscall just to account for extremely rare races. the solution is a huge hack: rather than blocking in the signal handler if the thread is dead, modify the signal mask of the saved context and return in order to prevent further signal handling by the dead thread. this allows the dead thread to continue decrementing the thread count (if it had not yet done so) and exiting, even while the live part of the program blocks for rsyscall.
2011-04-03don't trust siginfo in rsyscall handlerRich Felker-3/+2
for some inexplicable reason, linux allows the sender of realtime signals to spoof its identity. permission checks for sending signals should limit the impact to same-user processes, but just to be safe, we avoid trusting the siginfo structure and instead simply examine the program state to see if we're in the middle of a legitimate rsyscall.
2011-04-03simplify calling of timer signal handlerRich Felker-7/+4
2011-04-03simplify pthread tsd key handlingRich Felker-8/+6
2011-04-03omit pthread tsd dtor code if tsd is not usedRich Felker-14/+24
2011-04-01simplify setting result on thread cancellationRich Felker-1/+1
2011-04-01use bss instead of mmap for main thread's pthread thread-specific dataRich Felker-9/+4
this simplifies code and removes a failure case
2011-04-01fix misspelled PTHREAD_CANCELED constantRich Felker-1/+1
2011-04-01use a_store to set cancel flag in pthread_cancel, to ensure a barrierRich Felker-1/+1
2011-03-31simplify pthread_key_deleteRich Felker-1/+1
calling this function on an uninitialized key value is UB, so there is no need to check that the table pointer was initialized.
2011-03-31greatly simplify pthread_key_create (~20% size reduction)Rich Felker-10/+9
2011-03-30avoid crash on stupid but allowable usage of pthread_mutex_unlockRich Felker-1/+3
unlocking an unlocked mutex is not UB for robust or error-checking mutexes, so we must avoid calling __pthread_self (which might crash due to lack of thread-register initialization) until after checking that the mutex is locked.
2011-03-30streamline mutex unlock to remove a useless branch, use a_store to unlockRich Felker-2/+6
this roughly halves the cost of pthread_mutex_unlock, at least for non-robust, normal-type mutexes. the a_store change is in preparation for future support of archs which require a memory barrier or special atomic store operation, and also should prevent the possibility of the compiler misordering writes.
2011-03-30cheap special-case optimization for normal mutexesRich Felker-0/+4
cycle-level benchmark on atom cpu showed typical pthread_mutex_lock call dropping from ~120 cycles to ~90 cycles with this change. benefit may vary with compiler options and version, but this optimization is very cheap to make and should always help some.
2011-03-29revert mutex "optimization" that turned out to be worseRich Felker-1/+1
2011-03-29major improvements to cancellation handlingRich Felker-6/+13
- there is no longer any risk of spoofing cancellation requests, since the cancel flag is set in pthread_cancel rather than in the signal handler. - cancellation signal is no longer unblocked when running the cancellation handlers. instead, pthread_create will cause any new threads created from a cancellation handler to unblock their own cancellation signal. - various tweaks in preparation for POSIX timer support.
2011-03-28revert some more spin optimizations that turned out to be pessimizationsRich Felker-3/+2
2011-03-28fix broken spinlock due to miscompilationRich Felker-1/+1
actually this trick also seems to have made the uncontended case slower.
2011-03-25match glibc/lsb cancellation abi on i386Rich Felker-0/+36
glibc made the ridiculous choice to use pass-by-register calling convention for these functions, which is impossible to duplicate directly on non-gcc compilers. instead, we use ugly asm to wrap and convert the calling convention. presumably this works with every compiler anyone could potentially want to use.
2011-03-24prepare pthread_spin_unlock for archs that need memory barriersRich Felker-1/+2
2011-03-24optimize contended case for pthread_spin_trylockRich Felker-1/+2
2011-03-24optimize spinlock spinRich Felker-1/+1
2011-03-24overhaul cancellation to fix resource leaks and dangerous behavior with signalsRich Felker-10/+21
this commit addresses two issues: 1. a race condition, whereby a cancellation request occurring after a syscall returned from kernelspace but before the subsequent CANCELPT_END would cause cancellable resource-allocating syscalls (like open) to leak resources. 2. signal handlers invoked while the thread was blocked at a cancellation point behaved as if asynchronous cancellation mode wer in effect, resulting in potentially dangerous state corruption if a cancellation request occurs. the glibc/nptl implementation of threads shares both of these issues. with this commit, both are fixed. however, cancellation points encountered in a signal handler will not be acted upon if the signal was received while the thread was already at a cancellation point. they will of course be acted upon after the signal handler returns, so in real-world usage where signal handlers quickly return, it should not be a problem. it's possible to solve this problem too by having sigaction() wrap all signal handlers with a function that uses a pthread_cleanup handler to catch cancellation, patch up the saved context, and return into the cancellable function that will catch and act upon the cancellation. however that would be a lot of complexity for minimal if any benefit...
2011-03-20global cleanup to use the new syscall interfaceRich Felker-6/+5
2011-03-19if returning errno value directly from a syscall, we need to negate it.Rich Felker-2/+2
2011-03-19syscall overhaul part two - unify public and internal syscall interfaceRich Felker-15/+9
with this patch, the syscallN() functions are no longer needed; a variadic syscall() macro allows syscalls with anywhere from 0 to 6 arguments to be made with a single macro name. also, manually casting each non-integer argument with (long) is no longer necessary; the casts are hidden in the macros. some source files which depended on being able to define the old macro SYSCALL_RETURNS_ERRNO have been modified to directly use __syscall() instead of syscall(). references to SYSCALL_SIGSET_SIZE and SYSCALL_LL have also been changed. x86_64 has not been tested, and may need a follow-up commit to fix any minor bugs/oversights.
2011-03-19overhaul syscall interfaceRich Felker-2/+2
this commit shuffles around the location of syscall definitions so that we can make a syscall() library function with both SYS_* and __NR_* style syscall names available to user applications, provides the syscall() library function, and optimizes the code that performs the actual inline syscalls in the library itself. previously on i386 when built as PIC (shared library), syscalls were incurring bus lock (lock prefix) overhead at entry and exit, due to the way the ebx register was being loaded (xchg instruction with a memory operand). now the xchg takes place between two registers. further cleanup to arch/$(ARCH)/syscall.h is planned.
2011-03-17implement robust mutexesRich Felker-10/+78
some of this code should be cleaned up, e.g. using macros for some of the bit flags, masks, etc. nonetheless, the code is believed to be working and correct at this point.
2011-03-17avoid function call to pthread_self in mutex unlockRich Felker-1/+1
if the mutex was previously locked, we can assume pthread_self was already called at the time of locking, and thus that the thread pointer is initialized.
2011-03-17unify lock and owner fields of mutex structureRich Felker-7/+6
this change is necessary to free up one slot in the mutex structure so that we can use doubly-linked lists in the implementation of robust mutexes.
2011-03-17optimize contended normal mutex case; add int compare-and-swap atomicRich Felker-1/+1
2011-03-16simplify logic, slightly optimize contended case for non-default mutex typesRich Felker-4/+2
2011-03-16correct error returns for error-checking mutexesRich Felker-2/+6
2011-03-16cut out a syscall on thread creation in the case where guard size is 0Rich Felker-1/+1
2011-03-16don't expose EAGAIN, etc. from timed futex wait to callerRich Felker-1/+4
2011-03-12implement flockfile api, rework stdio lockingRich Felker-0/+1