summaryrefslogtreecommitdiff
path: root/src/stdio/fclose.c
AgeCommit message (Collapse)AuthorLines
2011-07-30add proper fuxed-based locking for stdioRich Felker-1/+1
previously, stdio used spinlocks, which would be unacceptable if we ever add support for thread priorities, and which yielded pathologically bad performance if an application attempted to use flockfile on a key file as a major/primary locking mechanism. i had held off on making this change for fear that it would hurt performance in the non-threaded case, but actually support for recursive locking had already inflicted that cost. by having the internal locking functions store a flag indicating whether they need to perform unlocking, rather than using the actual recursive lock counter, i was able to combine the conditionals at unlock time, eliminating any additional cost, and also avoid a nasty corner case where a huge number of calls to ftrylockfile could cause deadlock later at the point of internal locking. this commit also fixes some issues with usage of pthread_self conflicting with __attribute__((const)) which resulted in crashes with some compiler versions/optimizations, mainly in flockfile prior to pthread_create.
2011-05-02fix fclose return status logic, againRich Felker-1/+2
the previous fix was incorrect, as it would prevent f->close(f) from being called if fflush(f) failed. i believe this was the original motivation for using | rather than ||. so now let's just use a second statement to constrain the order of function calls, and to back to using |.
2011-05-01fix undefined call order in fclose, possible lost output depending on compilerRich Felker-1/+1
pcc turned up this bug by calling f->close(f) before fflush(f), resulting in lost output and error on flush.
2011-02-12initial check-in, version 0.5.0v0.5.0Rich Felker-0/+21