AgeCommit message (Collapse)AuthorLines
2013-11-09adjust sys/wait.h not to produde errors in strict ISO C feature profileRich Felker-3/+7
siginfo_t is not available from signal.h when the strict ISO C feature profile (e.g. passing -std=c99 to gcc without defining any other feature test macros) is used, but the type is needed to declare waitid. using sys/wait.h (or any POSIX headers) in strict ISO C mode is an application bug, but in the interest of compatibility, it's best to avoid producing gratuitous errors. the simplest fix I could find is suppressing the declaration of waitid (and also signal.h inclusion, since it's not needed for anything else) in this case, while still exposing everything else in sys/wait.h
2013-11-08remove O_NOFOLLOW from __map_file used for time zone file loadingRich Felker-1/+1
it's not clear why I originally wrote O_NOFOLLOW into this; I suspect the reason was with an aim of making the function more general for mapping partially or fully untrusted files provided by the user. however, the timezone code already precludes use of absolute or relative pathnames in suid/sgid programs, and disallows .. in pathnames which are relative to one of the system timezone locations, so there is no threat of opening a symlink which is not trusted by appropriate user. since some users may wish to put symbolic links in the zoneinfo directories to alias timezones, it seems preferable to allow this.
2013-11-08fix handling of overly-long TZ environment variable valuesRich Felker-1/+1
the rest of the code is not prepared to handle an empty TZ string, so falling back to __gmt ("GMT"), just as if TZ had been blank or unset, is the preferable action.
2013-11-04timezone parser: fix iteration over search dir pathsrofl0r-1/+1
try+l points to \0, so only one iteration was ever tried.
2013-11-04timezone parser: fix offset to transition table in 64bit code pathrofl0r-1/+1
we need to skip to the second TZif header, which starts at skip+44, and then skip another header (20 bytes) plus the following 6 32bit values.
2013-11-04fix timezone parser code crashing on 64bit sysrofl0r-1/+1
if sizeof(time_t) == 8, this code path was missing the correct offset into the zoneinfo file, using the header magic to do offset calculations. the 6 32bit fields to be read start at offset 20.
2013-11-02fix regression in inet_aton due to misinterpretation of __ipparse returnRich Felker-3/+3
inet_aton returns a boolean success value, whereas __ipparse returns 0 on success and -1 on failure. also change the conditional in inet_addr to be consistent with other uses of __ipparse where only negative values are treated as failure.
2013-11-01simplify faccessat AT_EACCESS path and eliminate resource dependenceRich Felker-14/+21
now that we're waiting for the exit status of the child process, the result can be conveyed in the exit status rather than via a pipe. since the error value might not fit in 7 bits, a table is used to translate possible meaningful error values to small integers.
2013-11-01fix faccessat AT_EACCESS path not to leave zombie processesRich Felker-2/+6
I mistakenly assumed that clone without a signal produced processes that would not become zombies; however, waitpid with __WCLONE is required to release their pids.
2013-10-30fix inttypes.h PRI and SCN macros for [u]intptr_t typesRich Felker-11/+13
while using "l" unconditionally gave the right behavior due to matching sizes/representations, it was technically UB and produced compiler warnings with format string checking.
2013-10-29POSIX conformance fix: define struct entry in search.hSzabolcs Nagy-9/+9
2013-10-28fenv: fix i386 fesetround for sseSzabolcs Nagy-1/+1
i386 fenv code checks __hwcap for sse support, but in fesetround the sse code was unconditionally jumped over after the test so the sse rounding mode was never set.
2013-10-28math: extensive log*.c cleanupSzabolcs Nagy-583/+369
The log, log2 and log10 functions share a lot of code and to a lesser extent log1p too. A small part of the code was kept separately in __log1p.h, but since it did not capture much of the common code and it was inlined anyway, it did not solve the issue properly. Now the log functions have significant code duplication, which may be resolved later, until then they need to be modified together. logl, log10l, log2l, log1pl: * Fix the sign when the return value should be -inf. * Remove the volatile hack from log10l (seems unnecessary) log1p, log1pf: * Change the handling of small inputs: only |x|<2^-53 is special (then it is enough to return x with the usual subnormal handling) this fixes the sign of log1p(0) in downward rounding. * Do not handle the k==0 case specially (other than skipping the elaborate argument reduction) * Do not handle 1+x close to power-of-two specially (this code was used rarely, did not give much speed up and the precision wasn't better than the general) * Fix the correction term formula (c=1-(u-x) was used incorrectly when x<1 but (double)(x+1)==2, this was not a critical issue) * Use the exact same method for calculating log(1+f) as in log (except in log1p the c correction term is added to the result). log, logf, log10, log10f, log2, log2f: * Use double_t and float_t consistently. * Now the first part of log10 and log2 is identical to log (until the return statement, hopefully this makes maintainence easier). * Most special case formulas were removed (close to power-of-two and k==0 cases), they increase the code size without providing precision or performance benefits (and obfuscate the code). Only x==1 is handled specially so in downward rounding mode the sign of zero is correct (the general formula happens to give -0). * For x==0 instead of -1/0.0 or -two54/0.0, return -1/(x*x) to force raising the exception at runtime. * Arg reduction code is changed (slightly simplified) * The thresholds for arg reduction to [sqrt(2)/2,sqrt(2)] are now consistently the [0x3fe6a09e00000000,0x3ff6a09dffffffff] and the [0x3f3504f3,0x3fb504f2] intervals for double and float reductions respectively (the exact threshold values are not critical) * Remove the obsolete comment for the FLT_EVAL_METHOD!=0 case in log2f (The same code is used for all eval methods now, on i386 slightly simpler code could be used, but we have asm there anyway) all: * Fix signed int arithmetics (using unsigned for bitmanipulation) * Fix various comments
2013-10-25add legacy ftime function and sys/timeb.hRich Felker-0/+34
despite being marked legacy, this was specified by SUSv3 as part of the XSI option; only the most recent version of the standard dropped it. reportedly there's actual code using it.
2013-10-23fix inet_ptonSzabolcs Nagy-26/+19
* parse IPv4 dotted-decimal correctly (without strtoul, no leading zeros) * disallow single leading ':' in IPv6 address * allow at most 4 hex digits in IPv6 address (according to RFC 2373) * have enough hex fields in IPv4 mapped IPv6 address * disallow leading zeros in IPv4 mapped IPv6 address
2013-10-22fix __ipparse to parse the generic numbers-and-dots IPv4 format correctlySzabolcs Nagy-5/+12
* allow at most 4 parts * bounds check the parts correctly * disallow leading whitespace and sign * check the address family before falling back to IPv6
2013-10-22fix inet_aton to accept the generic "numbers-and-dots" IPv4 address formatSzabolcs Nagy-1/+4
2013-10-21split inet_addr and inet_ntoa back into their own filesRich Felker-16/+21
despite being practically deprecated, these functions are still part of the standard and thus cannot reside in a file that also contains namespace pollution. this reverts some of the changes made in commit e40f48a421a9176e3e298b5bac75f0355b219e58.
2013-10-20fix multiple minor namespace issues in headersRich Felker-7/+15
fcntl.h: AT_* is not a reserved namespace so extensions cannot be exposed by default. langinfo.h: YESSTR and NOSTR were removed from the standard. limits.h: NL_NMAX was removed from the standard. signal.h: the conditional for NSIG was wrongly checking _XOPEN_SOURCE rather than _BSD_SOURCE. this was purely a mistake; it doesn't even match the commit message from the commit that added it.
2013-10-19fix return value for inet_pton in ipv6 failure casesRich Felker-6/+6
in the case of input that does not match the expected form, the correct return value is 0, not -1.
2013-10-18use consistent include guard name in arpa/ftp.hSzabolcs Nagy-2/+2
2013-10-18fix typo in socket.h (wrong macro name)Szabolcs Nagy-1/+1
2013-10-18in faccessat slow path, add close-on-exec to pipe fdsRich Felker-1/+1
as usual, this is needed to avoid fd leaks. as a better solution, the use of fds could possibly be replaced with mmap and a futex.
2013-10-12fix uid/gid-setting error in faccessat with AT_EACCESS flagRich Felker-2/+2
this fixes an issue reported by Daniel Thau whereby faccessat with the AT_EACCESS flag did not work in cases where the process is running suid or sgid but without root privileges. per POSIX, when the process does not have "appropriate privileges", setuid changes the euid, not the real uid, and the target uid must be equal to the current real or saved uid; if this condition is not met, EPERM results. this caused the faccessat child process to fail. using the setreuid syscall rather than setuid works. POSIX leaves it unspecified whether setreuid can set the real user id to the effective user id on processes without "appropriate privileges", but Linux allows this; if it's not allowed, there would be no way for this function to work.
2013-10-08fix errno value for getcwd when size argument is zeroRich Felker-1/+7
based on patch by Michael Forney. at the same time, I've changed the if branch to be more clear, avoiding the comma operator. the underlying issue is that Linux always returns ERANGE when size is too short, even when it's zero, rather than returning EINVAL for the special case of zero as required by POSIX.
2013-10-07math: fix rare underflow issue in fmaSzabolcs Nagy-13/+55
the issue is described in commits 1e5eb73545ca6cfe8b918798835aaf6e07af5beb and ffd8ac2dd50f99c3c83d7d9d845df9874ec3e7d5
2013-10-07math: use sqrtl if FLT_EVAL_METHOD==2 in acosh and acoshfSzabolcs Nagy-0/+13
this makes acosh slightly more precise around 1.0 on i386
2013-10-07fix clockid macro names in time.h, reported by Paul SchutteSzabolcs Nagy-2/+2
2013-10-07remove errno setting from setenv, malloc sets it correctly on oomSzabolcs Nagy-1/+0
2013-10-07fix allocation sizes in regcompSzabolcs Nagy-4/+4
sizeof had incorrect argument in a few places, the size was always large enough so the issue was not critical.
2013-10-07add missing va_end in execl* for correcness and static code analyzersSzabolcs Nagy-0/+3
2013-10-07minor vfprintf and vfwprintf changes to please static code analyzersSzabolcs Nagy-6/+11
add missing va_end and remove some unnecessary code.
2013-10-06math: remove an unused variable from modflSzabolcs Nagy-1/+0
2013-10-05slightly optimize __brk for sizeRich Felker-1/+1
there is no reason to check the return value for setting errno, since brk never returns errors, only the new value of the brk (which may be the same as the old, or otherwise differ from the requested brk, on failure). it may be beneficial to eventually just eliminate this file and make the syscalls inline in malloc.c.
2013-10-05fix failure of malloc to set errno on heap (brk) exhaustionRich Felker-0/+1
I wrongly assumed the brk syscall would set errno, but on failure it returns the old value of the brk rather than an error code.
2013-10-04fix failure to check malloc result in setenvRich Felker-9/+9
2013-10-04math: remove code duplication in erfl found by clang analyzerSzabolcs Nagy-13/+2
erfl had some superflous code left around after the last erf cleanup. the issue was reported by Alexander Monakov
2013-10-04math: remove a useless assignment in lgammal found by clang analyzerSzabolcs Nagy-2/+2
the issue was reported by Alexander Monakov
2013-10-04fix invalid implicit pointer conversion in pthread_key_createRich Felker-1/+1
2013-10-04fix uninitialized variable in dladdrRich Felker-1/+1
the affected branch only applies for DSOs that lack standard hash table and only have the GNU hash table present.
2013-10-04removed unused variable in vfwprintfRich Felker-2/+1
2013-10-03fix new environment always being null with execleRich Felker-2/+1
the va_arg call for the argv[]-terminating null pointer was missing, so this pointer was being wrongly used as the environment pointer. issue reported by Timo Teräs. proposed patch slightly modified to simplify the resulting code.
2013-09-29fix off-by-one error in getgrnam_r and getgrgid_r, clobbering gr_nameRich Felker-2/+2
bug report and patch by Michael Forney. the terminating null pointer at the end of the gr_mem array was overwriting the beginning of the string data, causing the gr_name member to always be a zero-length string.
2013-09-27fix buffer overflow in mbsrtowcsRich Felker-1/+1
issue reported by Michael Forney: "If wn becomes 0 after processing a chunk of 4, mbsrtowcs currently continues on, wrapping wn around to -1, causing the rest of the string to be processed. This resulted in buffer overruns if there was only space in ws for wn wide characters." the original patch submitted added an additional check for !wn after the loop; to avoid extra branching, I instead just changed the wn>=4 check to wn>=5 to ensure that at least one slot remains after the word-at-a-time loop runs. this should not slow down the tail processing on real-world usage, since an extra slot that can't be processed in the word-at-a-time loop is needed for the null termination anyway.
2013-09-27math: fix comparision macros (isless etc) when FLT_EVAL_METHOD!=0Szabolcs Nagy-10/+10
This is a change in ISO C11 annex F (F.10.11p1), comparision macros can't round their arguments to their semantic type when the evaluation format has wider range and precision. (ie. they must be consistent with the builtin relational operators)
2013-09-26add missing i386 syscall numbersRich Felker-0/+10
somehow the range 335-339 was missed when updating the file.
2013-09-26remove duplicate lines from mips bits/syscall.hRich Felker-48/+0
2013-09-23release notes for 0.9.14v0.9.14Rich Felker-0/+30
2013-09-22fix arm atomic store and generate simpler/less-bloated/faster codeRich Felker-6/+8
atomic store was lacking a barrier, which was fine for legacy arm with no real smp and kernel-emulated cas, but unsuitable for more modern systems. the kernel provides another "kuser" function, at 0xffff0fa0, which could be used for the barrier, but using that would drop support for kernels 2.6.12 through 2.6.14 unless an extra conditional were added to check for barrier availability. just using the barrier in the kernel cas is easier, and, based on my reading of the assembly code in the kernel, does not appear to be significantly slower. at the same time, other atomic operations are adapted to call the kernel cas function directly rather than using a_cas; due to small differences in their interface contracts, this makes the generated code much simpler.
2013-09-20fix potential deadlock bug in libc-internal locking logicRich Felker-13/+15
if a multithreaded program became non-multithreaded (i.e. all other threads exited) while one thread held an internal lock, the remaining thread would fail to release the lock. the the program then became multithreaded again at a later time, any further attempts to obtain the lock would deadlock permanently. the underlying cause is that the value of libc.threads_minus_1 at unlock time might not match the value at lock time. one solution would be returning a flag to the caller indicating whether the lock was taken and needs to be unlocked, but there is a simpler solution: using the lock itself as such a flag. note that this flag is not needed anyway for correctness; if the lock is not held, the unlock code is harmless. however, the memory synchronization properties associated with a_store are costly on some archs, so it's best to avoid executing the unlock code when it is unnecessary.