AgeCommit message (Collapse)AuthorLines
2013-03-09remove soname from Felker-1/+1
it serves no purpose (binaries linked against musl as -lc/ automatically get the right DT_NEEDED value of and causes ldconfig to misbehave (making a symlink to ld-musl named in /lib). ldconfig is not used on pure musl systems, but if ld-musl is installed on a system where it's not the primary libc, this will pollute the system /lib with a symlink to musl named, which should NOT exist and could cause problems linking native apps. also, the existence of the soname caused spurious warnings from ldconfig when /lib and /usr/lib were the same physical directory.
2013-03-06fix epoll structure alignment on non-x86_64 archsRich Felker-1/+5
this fix is far from ideal and breaks the rule of not using arch-specific #ifdefs, but for now we just need a solution to the existing breakage. the underlying problem is that the kernel folks made a very stupid decision to make misalignment of this struct part of the kernel API/ABI for x86_64, in order to avoid writing a few extra lines of code to handle both 32- and 64-bit userspace on 64-bit kernels. I had just added the packed attribute unconditionally thinking it was harmless on 32-bit archs, but non-x86 32-bit archs have 8-byte alignment on 64-bit types.
2013-03-06fix missing type error in grp.h from adding fgetgrentRich Felker-0/+4
2013-03-04fix types for wctype_t and wctrans_tRich Felker-16/+16
wctype_t was incorrectly "int" rather than "long" on x86_64. not only is this an ABI incompatibility; it's also a major design flaw if we ever wanted wctype_t to be implemented as a pointer, which would be necessary if locales support custom character classes, since int is too small to store a converted pointer. this commit fixes wctype_t to be unsigned long on all archs, matching the LSB ABI; this change does not matter for C code, but for C++ it affects mangling. the same issue applied to wctrans_t. glibc/LSB defines this type as const __int32_t *, but since no such definition is visible, I've just expanded the definition, int, everywhere. it would be nice if these types (which don't vary by arch) could be in wctype.h, but the OB XSI requirement in POSIX that wchar.h expose some types and functions from wctype.h precludes doing so. glibc works around this with some hideous hacks, but trying to duplicate that would go against the intent of musl's headers.
2013-03-04fix some obscure header type size/alignment issuesRich Felker-10/+9
2013-02-26fix wrong float_t on x86_64Rich Felker-1/+1
x86_64 does not have excess precision, at all
2013-02-26fix cruft in utmp.h that was broken by changes in utmpx.hRich Felker-3/+0
patch by Chris Spiegel.
2013-02-26fix integer type issue in strverscmpRich Felker-1/+3
lenl-lenr is not a valid expression for a signed int return value from strverscmp, since after implicit conversion from size_t to int this difference could have the wrong sign or might even be zero. using the difference for char values works since they're bounded well within the range of differences representable by int, but it does not work for size_t values.
2013-02-26implement non-stub strverscmpRich Felker-2/+35
patch by Isaac Dunham.
2013-02-26namespace conformance to latest standards in strings.hRich Felker-4/+6
2013-02-21replace stub with working strcasestrRich Felker-2/+4
2013-02-21fix wrong return value from wmemmove on forward copiesRich Felker-1/+2
2013-02-21scsci/sg.h: fix usage of undefined macro HZrofl0r-1/+1
this macro is 100 on all archs, at least in userspace, according to kernel headers.
2013-02-21add arpa/ftp.hrofl0r-0/+35
2013-02-20use memcmp instead of str[n]cmp for temp function XXXXXX checkingRich Felker-2/+2
2013-02-20fix error cases in mkostemps coreRich Felker-6/+3
1. wrong return value and missing errno for negative suffix len 2. failure to catch suffix len > strlen 3. remove unwanted clearing of input string in invalid case
2013-02-20remove leftover unused variable in mktemp after refactoringRich Felker-1/+0
2013-02-20add mkostemp, mkstemps, and mkostemps functions and reorganize temp internalsRich Felker-29/+91
based on patch contributed by Anthony G. Basile (blueness) some issues remain with the filename generation algorithm and other small bugs, but this patch has been sitting around long enough that I feel it's best to get it committed and then work out any remaining issues.
2013-02-17remove unused #undef environ now that libc.h no longer #defines itRich Felker-1/+0
2013-02-17consistently use the internal name __environ for environRich Felker-5/+4
patch by Jens Gustedt. previously, the intended policy was to use __environ in code that must conform to the ISO C namespace requirements, and environ elsewhere. this policy was not followed in practice anyway, making things confusing. on top of that, Jens reported that certain combinations of link-time optimization options were breaking with the inconsistent references; this seems to be a compiler or linker bug, but having it go away is a nice side effect of the changes made here.
2013-02-17add fgetgrent functionRich Felker-0/+13
based on patch by Isaac Dunham, moved to its own file to avoid increasing bss on static linked programs not using this nonstandard function but using the standard getgrent function, and vice versa.
2013-02-07fix typo in newly-added error message for EOWNERDEADRich Felker-1/+1
2013-02-07improve error stringsRich Felker-27/+30
this definitely has the potential to be a bikeshed topic, so some justification is in order. most of the changes made fit into one of the following categories: 1. alignment with text in posix, xsh 2.3 2. eliminating overly-specific text for shared error codes 3. making the message match more closely with the macro name 4. removing extraneous words in particular, the EAGAIN/EWOULDBLOCK text is updated to match the description of EAGAIN (which covers both uses) rather than saying the operation would block, and ENOTSUP/EOPNOTSUPP is updated not to mention sockets. the distinction between ENFILE/EMFILE has also been clarified; ENFILE is aligned with the posix text, and EMFILE, which lacks concise posix text matching any historic message, is updated to emphasize that the exhausted resource is not open files/open file descriptions, but rather the integer 'address space' of file descriptors. some messages may be further tweaked based on feedback.
2013-02-06arm: add __aeabi_atexit()rofl0r-0/+6
arm eabi requires this symbol for static C++ dtors. usually it is provided by libstdc++, but when a C++ program doesn't use the std lib (free-standing), the libc has to provide it. this was encountered while building transmission, which depends on such a C++ library (libutp). this function is nearly identical to __cxa_atexit, but it has the order of argumens swapped for "performance reasons". see page 25 of there are other aeabi specific C++ support functions missing, but it is not clear yet that GCC makes use of them so we omit them for the moment.
2013-02-06Makefile: make it possible to build arch specific C filesrofl0r-1/+1
2013-02-03base system() on posix_spawnRich Felker-41/+26
this avoids duplicating the fragile logic for executing an external program without fork.
2013-02-03fix unsigned comparison bug in posix_spawnRich Felker-1/+1
read should never return anything but 0 or sizeof ec here, but if it does, we want to treat any other return as "success". then the caller will get back the pid and is responsible for waiting on it when it immediately exits.
2013-02-03overhaul posix_spawn to use CLONE_VM instead of vforkRich Felker-55/+125
the proposed change was described in detail in detail previously on the mailing list. in short, vfork is unsafe because: 1. the compiler could make optimizations that cause the child to clobber the parent's local vars. 2. strace is buggy and allows the vforking parent to run before the child execs when run under strace. the new design uses a close-on-exec pipe instead of vfork semantics to synchronize the parent and child so that the parent does not return before the child has finished using its arguments (and now, also its stack). this also allows reporting exec failures to the caller instead of giving the caller a child that mysteriously exits with status 127 on exec error. basic testing has been performed on both the success and failure code paths. further testing should be done.
2013-02-03streamline old-kernel fallback path of pipe2 to use syscalls directlyRich Felker-4/+4
also, don't waste code/time on F_GETFL since pipes always have blank flags initially (at least on old kernels, which are all this fallback code matters for).
2013-02-03fix regression that made shared libs crash on armRich Felker-0/+4
2013-02-02dynamically allocate storage for gethostby* buffersRich Felker-10/+32
this change shaves ~1k off bss size, and also avoids hard errors in the case where the static buffer was not large enough to hold the result. this whole framework is really ugly and might should be replaced or at least heavily overhauled when some changes/factorizations are made to getaddrinfo internals in the future.
2013-02-02fix blank ai_canonname from getaddrinfo for non-CNAMEsRich Felker-1/+1
2013-02-02fix memory leak due to double call to getaddrinfo in gethostbyname*Rich Felker-1/+0
2013-02-02fix error returns in gethostby*_r functionsRich Felker-17/+10
they're supposed to return an error code rather than using errno.
2013-02-02fix uninitialized map_len being used in munmap failure paths in load_libraryRich Felker-3/+2
this bug seems to have been introduced when the map_library signatures was changed to return the mapping in a temp dso structure instead of into separate variables.
2013-02-01fix stale locks left behind when pthread_create failsRich Felker-3/+6
this bug seems to have been around a long time.
2013-02-01if pthread_create fails, it must not attempt mmap if there is no mappingRich Felker-1/+1
this bug was introduced when support for application-provided stacks was originally added.
2013-02-01pthread stack treatment overhaul for application-provided stacks, etc.Rich Felker-25/+35
the main goal of these changes is to address the case where an application provides a stack of size N, but TLS has size M that's a significant portion of the size N (or even larger than N), thus giving the application less stack space than it expected or no stack at all! the new strategy pthread_create now uses is to only put TLS on the application-provided stack if TLS is smaller than 1/8 of the stack size or 2k, whichever is smaller. this ensures that the application always has "close enough" to what it requested, and the threshold is chosen heuristically to make sure "sane" amounts of TLS still end up in the application-provided stack. if TLS does not fit the above criteria, pthread_create uses mmap to obtain space for TLS, but still uses the application-provided stack for actual call frame stack. this is to avoid wasting memory, and for the sake of supporting ugly hacks like garbage collection based on assumptions that the implementation will use the provided stack range. in order for the above heuristics to ever succeed, the amount of TLS space wasted on POSIX TSD (pthread_key_create based) needed to be reduced. otherwise, these changes would preclude any use of pthread_create without mmap, which would have serious memory usage and performance costs for applications trying to create huge numbers of threads using pre-allocated stack space. the new value of PTHREAD_KEYS_MAX is the minimum allowed by POSIX, 128. this should still be plenty more than real-world applications need, especially now that C11/gcc-style TLS is now supported in musl, and most apps and libraries choose to use that instead of POSIX TSD when available. at the same time, PTHREAD_STACK_MIN has been decreased. it was originally set to PAGE_SIZE back when there was no support for TLS or application-provided stacks, and requests smaller than a whole page did not make sense. now, there are two good reasons to support requests smaller than a page: (1) applications could provide pre-allocated stacks smaller than a page, and (2) with smaller stack sizes, stack+TLS+TSD can all fit in one page, making it possible for applications which need huge numbers of threads with minimal stack needs to allocate exactly one page per thread. the new value of PTHREAD_STACK_MIN, 2k, is aligned with the minimum size for sigaltstack.
2013-02-02make some arrays constrofl0r-8/+8
this way they'll go into .rodata, decreasing memory pressure.
2013-02-01replace __wake function with macro that performs direct syscallRich Felker-10/+2
this should generate faster and smaller code, especially with inline syscalls. the conditional with cnt is ugly, but thankfully cnt is always a constant anyway so it gets evaluated at compile time. it may be preferable to make separate __wake and __wakeall macros without a count argument. priv flag is not used yet; private futex support still needs to be done at some point in the future.
2013-02-01fix up minor misplacement of restrict keyword in spawnattr sched stubsRich Felker-2/+2
2013-02-01release notes for 0.9.9v0.9.9Rich Felker-0/+56
2013-02-01revert regex "cleanup" that seems unjustified and may break backtrackingRich Felker-0/+3
it's not clear to me at the moment whether the code that was removed (and which is now being re-added) is needed, but it's far from being a no-op, and i don't want to risk breaking regex in this release.
2013-01-31SOL_TCP is nonstandard and not in the reserved namespaceRich Felker-2/+1
alternatively, we could define it in sys/socket.h since SO* is reserved there, and tcp.h includes sys/socket.h in extensions mode. note that SOL_TCP is simply wrong and it's only here for compatibility with broken applications. the correct argument to pass for setting TCP socket options is IPPROTO_TCP, which of course has the same value as SOL_TCP but works everywhere.
2013-01-26fix tm_to_time logic for number of days in novemberRich Felker-1/+1
report/patch by Hiltjo Posthuma <>
2013-01-23add RTLD_NODELETE flag for dlopenRich Felker-0/+1
this is a trivial no-op, because dlclose never deletes libraries. thus we might as well have it in the header in case some application wants it, since we're already providing it anyway.
2013-01-23add support for RTLD_NOLOAD to dlopenRich Felker-3/+8
based on patch by Pierre Carrier <> that just added the flag constant, but with minimal additional code so that it actually works as documented. this is a nonstandard option but some major software (reportedly, Firefox) uses it and it was easy to add anyway.
2013-01-23fix regression in dlsym: rejection of special RTLD_* handles as invalidRich Felker-1/+2
2013-01-18use a common definition of NULL as 0L for C and C++Rich Felker-49/+8
the historical mess of having different definitions for C and C++ comes from the historical C definition as (void *)0 and the fact that (void *)0 can't be used in C++ because it does not convert to other pointer types implicitly. however, using plain 0 in C++ exposed bugs in C++ programs that call variadic functions with NULL as an argument and (wrongly; this is UB) expect it to arrive as a null pointer. on 64-bit machines, the high bits end up containing junk. glibc dodges the issue by using a GCC extension __null to define NULL; this is observably non-conforming because a conforming application could observe the definition of NULL via stringizing and see that it is neither an integer constant expression with value zero nor such an expression cast to void. switching to 0L eliminates the issue and provides compatibility with broken applications, since on all musl targets, long and pointers have the same size, representation, and argument-passing convention. we could maintain separate C and C++ definitions of NULL (i.e. just use 0L on C++ and use (void *)0 on C) but after careful analysis, it seems extremely difficult for a C program to even determine whether NULL has integer or pointer type, much less depend in subtle, unintentional ways, on whether it does. C89 seems to have no way to make the distinction. on C99, the fact that (int)(void *)0 is not an integer constant expression, along with subtle VLA/sizeof semantics, can be used to make the distinction, but many compilers are non-conforming and give the wrong result to this test anyway. on C11, _Generic can trivially make the distinction, but it seems unlikely that code targetting C11 would be so backwards in caring which definition of NULL an implementation uses. as such, the simplest path of using the same definition for NULL in both C and C++ was chosen. the #undef directive was also removed so that the compiler can catch and give a warning or error on redefinition if buggy programs have defined their own versions of NULL prior to inclusion of standard headers.
2013-01-16fix warning building dynlink.c stub for static libcRich Felker-2/+2
struct dso was not defined in this case, and it's not needed in the code that was using it anyway; void pointers work just as well.