summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorLines
2013-02-03fix unsigned comparison bug in posix_spawnRich Felker-1/+1
read should never return anything but 0 or sizeof ec here, but if it does, we want to treat any other return as "success". then the caller will get back the pid and is responsible for waiting on it when it immediately exits.
2013-02-03overhaul posix_spawn to use CLONE_VM instead of vforkRich Felker-55/+125
the proposed change was described in detail in detail previously on the mailing list. in short, vfork is unsafe because: 1. the compiler could make optimizations that cause the child to clobber the parent's local vars. 2. strace is buggy and allows the vforking parent to run before the child execs when run under strace. the new design uses a close-on-exec pipe instead of vfork semantics to synchronize the parent and child so that the parent does not return before the child has finished using its arguments (and now, also its stack). this also allows reporting exec failures to the caller instead of giving the caller a child that mysteriously exits with status 127 on exec error. basic testing has been performed on both the success and failure code paths. further testing should be done.
2013-02-03streamline old-kernel fallback path of pipe2 to use syscalls directlyRich Felker-4/+4
also, don't waste code/time on F_GETFL since pipes always have blank flags initially (at least on old kernels, which are all this fallback code matters for).
2013-02-03fix regression that made shared libs crash on armRich Felker-0/+4
2013-02-02dynamically allocate storage for gethostby* buffersRich Felker-10/+32
this change shaves ~1k off libc.so bss size, and also avoids hard errors in the case where the static buffer was not large enough to hold the result. this whole framework is really ugly and might should be replaced or at least heavily overhauled when some changes/factorizations are made to getaddrinfo internals in the future.
2013-02-02fix blank ai_canonname from getaddrinfo for non-CNAMEsRich Felker-1/+1
2013-02-02fix memory leak due to double call to getaddrinfo in gethostbyname*Rich Felker-1/+0
2013-02-02fix error returns in gethostby*_r functionsRich Felker-17/+10
they're supposed to return an error code rather than using errno.
2013-02-02fix uninitialized map_len being used in munmap failure paths in load_libraryRich Felker-3/+2
this bug seems to have been introduced when the map_library signatures was changed to return the mapping in a temp dso structure instead of into separate variables.
2013-02-01fix stale locks left behind when pthread_create failsRich Felker-3/+6
this bug seems to have been around a long time.
2013-02-01if pthread_create fails, it must not attempt mmap if there is no mappingRich Felker-1/+1
this bug was introduced when support for application-provided stacks was originally added.
2013-02-01pthread stack treatment overhaul for application-provided stacks, etc.Rich Felker-25/+35
the main goal of these changes is to address the case where an application provides a stack of size N, but TLS has size M that's a significant portion of the size N (or even larger than N), thus giving the application less stack space than it expected or no stack at all! the new strategy pthread_create now uses is to only put TLS on the application-provided stack if TLS is smaller than 1/8 of the stack size or 2k, whichever is smaller. this ensures that the application always has "close enough" to what it requested, and the threshold is chosen heuristically to make sure "sane" amounts of TLS still end up in the application-provided stack. if TLS does not fit the above criteria, pthread_create uses mmap to obtain space for TLS, but still uses the application-provided stack for actual call frame stack. this is to avoid wasting memory, and for the sake of supporting ugly hacks like garbage collection based on assumptions that the implementation will use the provided stack range. in order for the above heuristics to ever succeed, the amount of TLS space wasted on POSIX TSD (pthread_key_create based) needed to be reduced. otherwise, these changes would preclude any use of pthread_create without mmap, which would have serious memory usage and performance costs for applications trying to create huge numbers of threads using pre-allocated stack space. the new value of PTHREAD_KEYS_MAX is the minimum allowed by POSIX, 128. this should still be plenty more than real-world applications need, especially now that C11/gcc-style TLS is now supported in musl, and most apps and libraries choose to use that instead of POSIX TSD when available. at the same time, PTHREAD_STACK_MIN has been decreased. it was originally set to PAGE_SIZE back when there was no support for TLS or application-provided stacks, and requests smaller than a whole page did not make sense. now, there are two good reasons to support requests smaller than a page: (1) applications could provide pre-allocated stacks smaller than a page, and (2) with smaller stack sizes, stack+TLS+TSD can all fit in one page, making it possible for applications which need huge numbers of threads with minimal stack needs to allocate exactly one page per thread. the new value of PTHREAD_STACK_MIN, 2k, is aligned with the minimum size for sigaltstack.
2013-02-02make some arrays constrofl0r-8/+8
this way they'll go into .rodata, decreasing memory pressure.
2013-02-01replace __wake function with macro that performs direct syscallRich Felker-10/+2
this should generate faster and smaller code, especially with inline syscalls. the conditional with cnt is ugly, but thankfully cnt is always a constant anyway so it gets evaluated at compile time. it may be preferable to make separate __wake and __wakeall macros without a count argument. priv flag is not used yet; private futex support still needs to be done at some point in the future.
2013-02-01fix up minor misplacement of restrict keyword in spawnattr sched stubsRich Felker-2/+2
2013-02-01release notes for 0.9.9v0.9.9Rich Felker-0/+56
2013-02-01revert regex "cleanup" that seems unjustified and may break backtrackingRich Felker-0/+3
it's not clear to me at the moment whether the code that was removed (and which is now being re-added) is needed, but it's far from being a no-op, and i don't want to risk breaking regex in this release.
2013-01-31SOL_TCP is nonstandard and not in the reserved namespaceRich Felker-2/+1
alternatively, we could define it in sys/socket.h since SO* is reserved there, and tcp.h includes sys/socket.h in extensions mode. note that SOL_TCP is simply wrong and it's only here for compatibility with broken applications. the correct argument to pass for setting TCP socket options is IPPROTO_TCP, which of course has the same value as SOL_TCP but works everywhere.
2013-01-26fix tm_to_time logic for number of days in novemberRich Felker-1/+1
report/patch by Hiltjo Posthuma <hiltjo@codemadness.org>
2013-01-23add RTLD_NODELETE flag for dlopenRich Felker-0/+1
this is a trivial no-op, because dlclose never deletes libraries. thus we might as well have it in the header in case some application wants it, since we're already providing it anyway.
2013-01-23add support for RTLD_NOLOAD to dlopenRich Felker-3/+8
based on patch by Pierre Carrier <pierre@gcarrier.fr> that just added the flag constant, but with minimal additional code so that it actually works as documented. this is a nonstandard option but some major software (reportedly, Firefox) uses it and it was easy to add anyway.
2013-01-23fix regression in dlsym: rejection of special RTLD_* handles as invalidRich Felker-1/+2
2013-01-18use a common definition of NULL as 0L for C and C++Rich Felker-49/+8
the historical mess of having different definitions for C and C++ comes from the historical C definition as (void *)0 and the fact that (void *)0 can't be used in C++ because it does not convert to other pointer types implicitly. however, using plain 0 in C++ exposed bugs in C++ programs that call variadic functions with NULL as an argument and (wrongly; this is UB) expect it to arrive as a null pointer. on 64-bit machines, the high bits end up containing junk. glibc dodges the issue by using a GCC extension __null to define NULL; this is observably non-conforming because a conforming application could observe the definition of NULL via stringizing and see that it is neither an integer constant expression with value zero nor such an expression cast to void. switching to 0L eliminates the issue and provides compatibility with broken applications, since on all musl targets, long and pointers have the same size, representation, and argument-passing convention. we could maintain separate C and C++ definitions of NULL (i.e. just use 0L on C++ and use (void *)0 on C) but after careful analysis, it seems extremely difficult for a C program to even determine whether NULL has integer or pointer type, much less depend in subtle, unintentional ways, on whether it does. C89 seems to have no way to make the distinction. on C99, the fact that (int)(void *)0 is not an integer constant expression, along with subtle VLA/sizeof semantics, can be used to make the distinction, but many compilers are non-conforming and give the wrong result to this test anyway. on C11, _Generic can trivially make the distinction, but it seems unlikely that code targetting C11 would be so backwards in caring which definition of NULL an implementation uses. as such, the simplest path of using the same definition for NULL in both C and C++ was chosen. the #undef directive was also removed so that the compiler can catch and give a warning or error on redefinition if buggy programs have defined their own versions of NULL prior to inclusion of standard headers.
2013-01-16fix warning building dynlink.c stub for static libcRich Felker-2/+2
struct dso was not defined in this case, and it's not needed in the code that was using it anyway; void pointers work just as well.
2013-01-16fix bug in dladdr that prevented resolving addresses in the PLTRich Felker-1/+1
2013-01-15remove unused "params" related code from regexSzabolcs Nagy-21/+11
some structs and functions had reference to the params feature of tre that is not used by the code anymore
2013-01-14Merge remote-tracking branch 'nsz/math'Rich Felker-297/+207
2013-01-14regex: remove an unused local variable from regexecSzabolcs Nagy-3/+0
pos_start local variable is not used in tre_tnfa_run_backtrack
2013-01-13in crypt_des change unnecessary union keybuf into unsigned char[]Szabolcs Nagy-11/+8
original FreeSec code accessed keybuf as uint32* and uint8* as well (incorrectly), this got fixed with an union, but then it seems the uint32* access is no longer needed so the code can be simplified
2013-01-13crypt: fix the prototype of md5_sum, sha256_sum and sha512_sumSzabolcs Nagy-3/+3
the internal sha2 hash sum functions had incorrect array size in the prototype for the message digest argument, fixed by using pointer so it is not misleading
2013-01-13fix lio_listio return value in LIO_WAIT modeSzabolcs Nagy-1/+1
2013-01-12add MOD_TAI to sys/timex.h and update STA_RONLYSzabolcs Nagy-1/+2
2013-01-12add SWAP_FLAG_DISCARD to sys/swap.hSzabolcs Nagy-0/+1
2013-01-12add mount flags to sys/mount.hSzabolcs Nagy-4/+22
added various MS_*, MNT_*, UMOUNT_* flags following the linux headers, with one exception: MS_NOUSER is defined as (1U<<31) instead of (1<<31) which invokes undefined behaviour the S_* flags were removed following glibc
2013-01-12add IN_EXCL_UNLINK to sys/inotify.hSzabolcs Nagy-0/+1
2013-01-12add EPOLLWAKEUP flag to sys/epoll.hSzabolcs Nagy-0/+1
2013-01-12add RB_SW_SUSPEND and RB_KEXEC to sys/reboot.hSzabolcs Nagy-0/+2
using the glibc names for the magic constants of the linux reboot syscall
2013-01-12add missing mmap options and madvices to bits/mman.h based on linux headersSzabolcs Nagy-0/+41
2013-01-12add missing EXTPROC flag to bits/termios.hSzabolcs Nagy-0/+4
mips and powerpc already had this termios flag defined
2013-01-12add missing F_GETOWNER_UIDS flag to bits/fcntl.hSzabolcs Nagy-0/+11
2013-01-12add missing EHWPOISON to bits/errno.hSzabolcs Nagy-0/+5
it was already defined for mips, but was missing from other archs
2013-01-12add missing ptrace requests and options to sys/ptrace.hSzabolcs Nagy-1/+9
2013-01-12add missing multicast socket options to netinet/in.hSzabolcs Nagy-0/+17
based on linux headers add the missing MCAST_* options under _GNU_SOURCE as they are not in the reserved namespace (this api was originally specified by RFC 3678)
2013-01-12add missing protocol families to sys/socket.hSzabolcs Nagy-1/+11
missing protocol families based on current linux headers: PF_RDS, PF_LLC, PF_CAN, PF_TIPC, PF_NFC
2013-01-10fix another case of cloexec/nonblock flags not matching arch valuesRich Felker-2/+3
2013-01-10check for invalid handles in dlsym/dlcloseRich Felker-1/+17
this is wasteful and useless from a standpoint of sane programs, but it is required by the standard, and the current requirements were upheld with the closure of Austin Group issue #639: http://austingroupbugs.net/view.php?id=639
2013-01-07math: erf and erfc cleanupSzabolcs Nagy-297/+207
common part of erf and erfc was put in a separate function which saved some space and the new code is using unsigned arithmetics erfcf had a bug: for some inputs in [7.95,8] the result had more than 60ulp error: in expf(-z*z - 0.5625f) the argument must be exact but not enough lowbits of z were zeroed, -SET_FLOAT_WORD(z, ix&0xfffff000); +SET_FLOAT_WORD(z, ix&0xffffe000); fixed the issue
2013-01-04setjmp.h: add struct tag for sigjmp_buf (GCC C++ compatibility)rofl0r-1/+1
the anonymous struct typedef with array notation breaks with GCC in C++ mode: error: non-local function 'static<anonymous struct> (& boost::signal_handler::jump_buffer())[1]' uses anonymous type this is a known GCC issue, as search results for that error msg suggest. since this is hard to work around in the calling C++ code, a fix in musl is preferable.
2013-01-04add legacy header values.hrofl0r-0/+40
some programs (procps, babl) expect it, and it doesn't seem to cause any harm to just add it. it's small and straightforward. since math.h also defines MAXFLOAT, we undef it in both places, before defining it.
2013-01-04time.h: add BSD aliases for otherwise internal struct tm membersrofl0r-0/+4