summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorLines
2014-05-20fix missing SO_RCVBUFFORCE and SO_SNDBUFFORCE in mips socket.hRich Felker-1/+2
(cherry picked from commit 468bc11ed059c475f974920ac3d499e6071a6b2c)
2014-05-20fix superh nofpu check on old gcc versionsBobby Bingham-1/+1
As far as gcc3 knows, sh4 is the only processor version that can have an FPU, so it indicates the FPU's presence by defining __SH4__. This is not defined if there is no FPU, even if the processor really is an SH4. Starting with gcc4, there is support for the sh2a processor, which has an FPU but is not an SH4. gcc4 therefore additionally defines __SH_FPU_ANY__ when there is an FPU, but still doesn't define __SH4__ for an FPU-less sh4. Therefore, to support all gcc versions, we must look at both preprocessor symbols. (cherry picked from commit 23d64182d8328c300b368446aad20da9cec91aa3)
2014-05-20perform minimal sanity checks on zoneinfo files loaded via TZ variableRich Felker-0/+5
previously, setting TZ to the pathname of a file which was not a valid zoneinfo file would usually cause programs using local time zone based operations to crash. the new code checks the file size and magic at the beginning of the file, which seems sufficient to prevent accidental misconfiguration from causing crashes. attempting to make fully-robust validation would be futile unless we wanted to drop use of mmap (shared zoneinfo) and instead read it into a local buffer, since such validation would be subject to race conditions with modification of the file. (cherry picked from commit c3d9d172b1fcd56c4d356798f4e3b4653076bcc3)
2014-05-20fix false negatives with periodic needles in strstr, wcsstr, and memmemRich Felker-3/+3
in cases where the memorized match range from the right factor exceeded the length of the left factor, it was wrongly treated as a mismatch rather than a match. issue reported by Yves Bastide. (cherry picked from commit 476cd1d96560aaf7f210319597556e7fbcd60469)
2014-04-16release 1.0.1v1.0.1Rich Felker-1/+19
2014-04-16fix deadlock race in pthread_onceRich Felker-2/+1
at the end of successful pthread_once, there was a race window during which another thread calling pthread_once would momentarily change the state back from 2 (finished) to 1 (in-progress). in this case, the status was immediately changed back, but with no wake call, meaning that waiters which arrived during this short window could block forever. there are two possible fixes. one would be adding the wake to the code path where it was missing. but it's better just to avoid reverting the status at all, by using compare-and-swap instead of swap. (cherry picked from commit 0d0c2f40344640a2a6942dda156509593f51db5d)
2014-04-16fix RLIMIT_ constants for mipsSzabolcs Nagy-2/+10
The mips arch is special in that it uses different RLIMIT_ numbers than other archs, so allow bits/resource.h to override the default RLIMIT_ numbers (empty on all archs except mips). Reported by orc. (cherry picked from commit fcea534e579077e10456f6ed06c033dfaa013a24)
2014-04-16fix fallback code for old kernels in clock_gettimeRich Felker-1/+1
(cherry picked from commit 805698401dbac7ce3079fa97eaad5ba0508377f4)
2014-04-16use hidden visibility rather than protected for syscall internalsRich Felker-1/+1
the use of visibility at all is purely an optimization to avoid the need for the caller to load the GOT register or similar to prepare for a call via the PLT. there is no reason for these symbols to be externally visible, so hidden works just as well as protected, and using protected visibility is undesirable due to toolchain bugs and the lack of testing it receives. in particular, GCC's microblaze target is known to generate symbolic relocations in the GOT for functions with protected visibility. this in turn results in a dynamic linker which crashes under any nontrivial usage that requires making a syscall before symbolic relocations are processed. (cherry picked from commit 83c98aac4c43f9571e8f92a1c795afe02c237d4b)
2014-04-16math: fix aliasing violation in long double wrappersSzabolcs Nagy-2/+10
modfl and sincosl were passing long double* instead of double* to the wrapped double precision functions (on archs where long double and double have the same size). This is fixed now by using temporaries (this is not optimized to a single branch so the generated code is a bit bigger). Found by Morten Welinder. (cherry picked from commit 73c870ed3209b68b5c8c350534508cc9d95a6bcb)
2014-04-16fix search past the end of haystack in memmemTimo Teräs-0/+1
to optimize the search, memchr is used to find the first occurrence of the first character of the needle in the haystack before switching to a search for the full needle. however, the number of characters skipped by this first step were not subtracted from the haystack length, causing memmem to search past the end of the haystack. (cherry picked from commit 6fbdeff0e51f6afc38fbb1476a4db81322779da4)
2014-04-16fix printf rounding with %g for some corner case midpointsRich Felker-1/+1
the subsequent rounding code assumes the end pointer (z) accurately reflects the end of significance in the decimal expansion, but for certain large integers, spurious trailing zero slots were left behind when applying the binary exponent. issue reported by Morten Welinder; the analysis of the cause was performed by nsz, who also proposed this change. (cherry picked from commit e94d0692864ecf9522fd6a97610a47a2f718d3de)
2014-04-16fix failure of printf %g to strip trailing zeros in some casesRich Felker-1/+1
the code to strip trailing zeros was only looking in the last slot for up to 9 zeros, assuming that the rounding code had already removed fully-zero slots from the end. however, this ignored cases where the rounding code did not run at all, which occur when the value being printed is exactly representable in the requested precision. the simplest solution is to move the code that strips trailing zero slots to run unconditionally, immediately after rounding, rather than as the last step of rounding. (cherry picked from commit 89740868c9f1c84b8ee528468d12df1fa72cd392)
2014-04-16fix carry into uninitialized slots during printf floating point roundingRich Felker-1/+1
in cases where rounding caused a carry, the slot into which the carry was taking place was unconditionally treated as valid, despite the possibility that it could be a new slot prior to the beginning of the existing non-rounded number. in theory this could lead to unbounded runaway carry, but in order for that to happen, the whole uninitialized buffer would need to have been pre-filled with 32-bit integer values greater than or equal to 999999999. patch based on proposed fix by Morten Welinder, who also discovered and reported the bug. (cherry picked from commit 109048e031f39fbb370211fde44ababf6c04c8fb)
2014-04-16fix microblaze syscall register clobbersRich Felker-7/+7
the kernel entry point for syscalls on microblaze nominally saves and restores all registers, and testing on qemu always worked since qemu behaves this way too. however, the real kernel treats r3:r4 as a potential 64-bit return value from the syscall function, and copies both over top of the saved registers before returning to userspace. thus, we need to treat r4 as always-clobbered. (cherry picked from commit 91d5aa06572d2660122f9a06ed242fef0383f292)
2014-04-16fix confstr return valueTimo Teräs-1/+1
per the specification, the terminating null byte is counted. (cherry picked from commit 0a8d98285f46f721dabf38485df916c02d6a4675)
2014-04-16include header that declares __syscall_ret where it's definedRich Felker-0/+1
in general, we aim to always include the header that's declaring a function before defining it so that the compiler can check that prototypes match. additionally, the internal syscall.h declares __syscall_ret with a visibility attribute to improve code generation for shared libc (to prevent gratuitous GOT-register loads). this declaration should be visible at the point where __syscall_ret is defined, too, or the inconsistency could theoretically lead to problems at link-time. (cherry picked from commit 30c1205acd73c8481ca34f0a41de1d41884d07b5)
2014-03-20release 1.0.0v1.0.0Rich Felker-1/+43
2014-03-20remove claim of XSI coverage from READMERich Felker-2/+1
in addition to the dbm functions (which we don't intent to implement anyway), fmtmsg is still missing too. rather than adding exceptions I think it's best just to avoid making the claim.
2014-03-20update README in preparation for releaseRich Felker-59/+21
reduces the amount of news-like content on progress and development direction and focuses on the present.
2014-03-20update INSTALL file with new information and better adviceRich Felker-109/+114
the text covering an ill-advised procedure for 'bootstrapping' a new musl-based system in-place is removed. new information on targets and compilers is added. formatting improved. the remaining text is adjusted to cover both usage with musl-gcc on a non-musl-based system and upgrading a musl-based system or toolchain.
2014-03-20update COPYRIGHT file with additional contributor informationRich Felker-22/+54
2014-03-19configure: check for __ILP32__ if arch is x86_64rofl0r-0/+4
otherwise a multilib compiler used with -mx32 will not be detected properly.
2014-03-18fix signal.h breakage from moving stack_t to arch-specific bitsRich Felker-48/+50
in the previous changes, I missed the fact that both the prototype of the sigaltstack function and the definition of ucontext_t depend on stack_t.
2014-03-18fix mips stack_tRich Felker-1/+1
like almost everything on mips, this is gratuitously different.
2014-03-18move signal.h definition of stack_t to arch-specific bitsRich Felker-6/+48
it's different at least on mips. mips version will be fixed in a separate commit to show the change.
2014-03-18fix mips sigsetjmp asm to match fixed jmp_buf sizeRich Felker-1/+1
this was missed in the previous commit.
2014-03-18fix typo in filename used in sh portRich Felker-0/+0
2014-03-18fix size of mips jmp_bufRich Felker-1/+1
the excess space was unused and unintentional. this change does not affect the ABI between applications and libc. while it does theoretically affect linkage between third-party translation units using jmp_buf as part of a structure, we've already changed jmp_buf at least once on all archs, and problems were never observed, likely because such usage would be very unusual. in any case it's best to get things right now rather than making changes sometime during the 1.0.x series or later.
2014-03-18remove useless and incorrect uc_regspace member from mips ucontext_tRich Felker-1/+0
this seems to have been copied erroneously from the arm version of the file. it's fairly harmless but it's a mistake and better to fix now than later.
2014-03-18use syscall_arg_t for arguments in public syscall() functionRich Felker-7/+7
on x32, this change allows programs which use syscall() with pointers or 64-bit values as arguments to work correctly, i.e. without truncation or incorrect sign extension. on all other supported archs, syscall_arg_t is defined as long, so this change is a no-op.
2014-03-17make configure accept alternate gcc tuples for x32Rich Felker-1/+1
the previous pattern required "x32" to be used as the second field of the gcc tuple, which is usually reserved for vendor use and not appropriate as an ABI specifier. with this change, putting "x32" at the end of the tuple, the way ABI specifiers are normally done, is also permitted.
2014-03-17x32: fix struct statfsrofl0r-2/+4
the omission of the padding was uncovered by the latest regression statvfs regression test added to libc-test.
2014-03-17fix negated error codes from ptsname_rRich Felker-1/+1
the incorrect error codes also made their way into errno when __ptsname_r was called by plain ptsname, which reports errors via errno rather than a return value.
2014-03-16superh: fix dynamic linking of __fpscr_valuesBobby Bingham-1/+7
Applications ended up with copy relocations for this array, which resulted in libc's references to this array pointing to the application's copy. The dynamic linker, however, can require this array before the application is relocated, and therefore before the application's copy of this array is initialized. This resulted in garbage being loaded into FPSCR before executing main, which violated the ABI. We fix this by putting the array in crt1 and making the libc copy private. This prevents libc's reference to the array from pointing to an uninitialized copy in the application.
2014-03-13semctl: fix UB causing crashes on powerpcrofl0r-4/+8
it's UB to fetch variadic args when none are passed, and this caused real crashes on ppc due to its calling convention, which defines that for variadic functions aggregate types be passed as pointers. the assignment caused that pointer to get dereferenced, resulting in a crash.
2014-03-12fix statfs struct on mipsSzabolcs Nagy-3/+4
The mips statfs struct layout is different than on other archs, so the statfs, fstatfs, statvfs and fstatvfs APIs were broken on mips. Now the ordering is fixed, the types are kept consistent with other archs.
2014-03-12fix semid_ds structure on mipsSzabolcs Nagy-2/+0
This used to be broken when all archs had the same semid_ds definition: there is no padding around the time_t members on mips.
2014-03-11fix socket.h struct msghdr member types on powerpcRich Felker-4/+4
these were incorrectly copied from the kernel, whose ABI matches the POSIX requirements but with the wrong underlying types and wrong signedness.
2014-03-11fix sysvipc structures on powerpcRich Felker-20/+16
these have been wrong for a long time and were never detected or corrected. powerpc needs some gratuitous extra padding/reserved slots in ipc_perm, big-endian ordering for the padding of time_t slots that was intended by the kernel folks to allow a transition to 64-bit time_t, and some minor gratuitous reordering of struct members.
2014-03-11move struct semid_ds to from shared sys/sem.h to bitsRich Felker-16/+129
the definition was found to be incorrect at least for powerpc, and fixing this cleanly requires making the definition arch-specific. this will allow cleaning up the definition for other archs to make it more specific, and reversing some of the ugliness (time_t hacks) introduced with the x32 port. this first commit simply copies the existing definition to each arch without any changes. this is intentional, to make it easier to review changes made on a per-arch basis.
2014-03-09math.h: make __FLOAT_BITS and __DOUBLE_BITS C89Szabolcs Nagy-2/+4
Remove non-constant aggregate initializer. (Still using long long, but that is supported by ancient compilers without __extension__ anyway).
2014-03-09fix incorrect rounding in printf floating point corner casesRich Felker-2/+2
the printf floating point formatting code contains an optimization to avoid computing digits that will be thrown away by rounding at the specified (or default) precision. while it was correctly retaining all places up to the last decimal place to be printed, it was not retaining enough precision to see the next nonzero decimal place in all cases. this could cause incorrect rounding down in round-to-even (default) rounding mode, for example, when printing 0.5+DBL_EPSILON with "%.0f". in the fix, LDBL_MANT_DIG/3 is a lazy (non-sharp) upper bound on the number of zeros between any two nonzero decimal digits.
2014-03-09fix buffer overflow in printf formatting of denormals with low bit setRich Felker-1/+2
empirically the overflow was an off-by-one, and it did not seem to be overwriting meaningful data. rather than simply increasing the buffer size by one, however, I have attempted to make the size obviously correct in terms of bounds on the number of iterations for the loops that fill the buffer. this still results in no more than a negligible size increase of the buffer on the stack (6-7 32-bit slots) and is a "safer" fix unless/until somebody wants to do the proof that a smaller buffer would suffice.
2014-03-08in sys/procfs.h, avoid using __WORDSIZE macroRich Felker-1/+1
this was problematic because several archs don't define __WORDSIZE. we could add it, but I would rather phase this macro out in the long term. in our version of the headers, UINTPTR_MAX is available here, so just use it instead.
2014-03-08add bits/user.h for sh portRich Felker-0/+75
this seems to have been overlooked, and resulted in breakage in anything including sys/user.h.
2014-03-07in fcntl, use unsigned long instead of long for variadic argument typeRich Felker-2/+2
neither is correct; different commands take different argument types, and some take no arguments at all. I have a much larger overhaul of fcntl prepared to address this, but it's not appropriate to commit during freeze. the immediate problem being addressed affects forward-compatibility on x32: if new commands are added and they take pointers, but the libc-level fcntl function is not aware of them, using long would sign-extend the pointer to 64 bits and give the kernel an invalid pointer. on the kernel side, the argument to fcntl is always treated as unsigned long, so no harm is done by treating possibly-signed integer arguments as unsigned. for every command that takes an integer argument except for F_SETOWN, large integer arguments and negative arguments are handled identically anyway. in the case of F_SETOWN, the kernel is responsible for converting the argument which it received as unsigned long to int, so the sign of negative arguments is recovered. the other problem that will be addressed later is that the type passed to va_arg does not match the type in the caller of fcntl. an advanced compiler doing cross-translation-unit analysis could potentially see this mismatch and issue warnings or otherwise make trouble. on i386, this patch was confirmed not to alter the code generated by gcc 4.7.3. in principle the generated code should not be affected on any arch except x32.
2014-03-06update copyright dates to 2014Rich Felker-2/+2
2014-03-06x32: fix sysinfo()rofl0r-0/+52
the kernel uses long longs in the struct, but the documentation says they're long. so we need to fixup the mismatch between the userspace and kernelspace structs. since the struct offers a mem_unit member, we can avoid truncation by adjusting that value.
2014-03-05fix strerror on mips: one error code is out of the 8-bit table rangeRich Felker-1/+7
if we ever encounter other targets where error codes don't fit in the 8-bit range, the table should probably just be bumped to 16-bit, but for now I don't want to increase the table size on all archs just because of a bug in the mips abi.