path: root/src/thread/powerpc
diff options
authorRich Felker <>2015-04-14 11:18:59 -0400
committerRich Felker <>2015-04-14 11:18:59 -0400
commitcbc02ba23cec16d7a821648ea8424546bc7f02dc (patch)
treec3650ae9dc0fe3506365371cb0fd0358df6597cf /src/thread/powerpc
parentbc081f628b51337b525ca2d53aeff1b971f092f5 (diff)
consistently use hidden visibility for cancellable syscall internals
in a few places, non-hidden symbols were referenced from asm in ways that assumed ld-time binding. while these is no semantic reason these symbols need to be hidden, fixing the references without making them hidden was going to be ugly, and hidden reduces some bloat anyway. in the asm files, .global/.hidden directives have been moved to the top to unclutter the actual code.
Diffstat (limited to 'src/thread/powerpc')
1 files changed, 10 insertions, 3 deletions
diff --git a/src/thread/powerpc/syscall_cp.s b/src/thread/powerpc/syscall_cp.s
index 0c7869cc..20b5e0ac 100644
--- a/src/thread/powerpc/syscall_cp.s
+++ b/src/thread/powerpc/syscall_cp.s
@@ -1,3 +1,13 @@ __cp_begin
+.hidden __cp_begin __cp_end
+.hidden __cp_end __cp_cancel
+.hidden __cp_cancel
+.hidden __cancel __syscall_cp_asm
+.hidden __syscall_cp_asm
#r0: volatile. may be modified during linkage.
#r1: stack frame: 16 byte alignment.
#r2: tls/thread pointer on pp32
@@ -16,11 +26,9 @@
#the fields CR2,CR2,CR4 of the cond reg must be preserved
#LR (link reg) shall contain the funcs return address
- .global __syscall_cp_asm
.type __syscall_cp_asm,%function
# at enter: r3 = pointer to self->cancel, r4: syscall no, r5: first arg, r6: 2nd, r7: 3rd, r8: 4th, r9: 5th, r10: 6th
- .global __cp_begin
# r3 holds first argument, its a pointer to self->cancel.
# we must compare the dereferenced value with 0 and jump to __cancel if its not
@@ -42,7 +50,6 @@ __cp_begin:
mr 7, 9 # arg5
mr 8, 10 # arg6
- .global __cp_end
bnslr+ # return if no summary overflow.
#else negate result.