path: root/src/signal/sigismember.c
diff options
authorRich Felker <>2013-08-09 21:03:47 -0400
committerRich Felker <>2013-08-09 21:03:47 -0400
commit3c5c5e6f926feea7b823a96c2872885b100fe31f (patch)
treebec398659ee1f88f8150348940c2a7c843c395fe /src/signal/sigismember.c
parent65d7aa4dfde9697b93d765f2f736e5f4a38bdfd5 (diff)
optimize posix_spawn to avoid spurious sigaction syscalls
the trick here is that sigaction can track for us which signals have ever had a signal handler set for them, and only those signals need to be considered for reset. this tracking mask may have false positives, since it is impossible to remove bits from it without race conditions. false negatives are not possible since the mask is updated with atomic operations prior to making the sigaction syscall. implementation-internal signals are set to SIG_IGN rather than SIG_DFL so that a signal raised in the parent (e.g. calling pthread_cancel on the thread executing pthread_spawn) does not have any chance make it to the child, where it would cause spurious termination by signal. this change reduces the minimum/typical number of syscalls in the child from around 70 to 4 (including execve). this should greatly improve the performance of posix_spawn and other interfaces which use it (popen and system). to facilitate these changes, sigismember is also changed to return 0 rather than -1 for invalid signals, and to return the actual status of implementation-internal signals. POSIX allows but does not require an error on invalid signal numbers, and in fact returning an error tends to confuse applications which wrongly assume the return value of sigismember is boolean.
Diffstat (limited to 'src/signal/sigismember.c')
1 files changed, 1 insertions, 4 deletions
diff --git a/src/signal/sigismember.c b/src/signal/sigismember.c
index e887b95f..1a22108b 100644
--- a/src/signal/sigismember.c
+++ b/src/signal/sigismember.c
@@ -4,9 +4,6 @@
int sigismember(const sigset_t *set, int sig)
unsigned s = sig-1;
- if (s >= 8*sizeof(sigset_t) || sig-32U<3) {
- errno = EINVAL;
- return -1;
- }
+ if (s >= 8*sizeof(sigset_t)) return 0;
return !!(set->__bits[s/8/sizeof *set->__bits] & 1UL<<(s&8*sizeof *set->__bits-1));