path: root/src/ldso/x86_64/tlsdesc.s
diff options
authorRich Felker <>2015-04-14 23:45:08 -0400
committerRich Felker <>2015-04-14 23:45:08 -0400
commit81e18eb3cd61f7b68a8f99b3e6c728f2a4d79221 (patch)
tree2ea334c40a3b59607be4f3f9ae524cdcf5b69d21 /src/ldso/x86_64/tlsdesc.s
parent9c738dc183f44de40d263e4ff8dc540915a41aed (diff)
use hidden __tls_get_new for tls/tlsdesc lookup fallback cases
previously, the dynamic tlsdesc lookup functions and the i386 special-ABI ___tls_get_addr (3 underscores) function called __tls_get_addr when the slot they wanted was not already setup; __tls_get_addr would then in turn also see that it's not setup and call __tls_get_new. calling __tls_get_new directly is both more efficient and avoids the issue of calling a non-hidden (public API/ABI) function from asm. for the special i386 function, a weak reference to __tls_get_new is used since this function is not defined when static linking (the code path that needs it is unreachable in static-linked programs).
Diffstat (limited to 'src/ldso/x86_64/tlsdesc.s')
1 files changed, 3 insertions, 1 deletions
diff --git a/src/ldso/x86_64/tlsdesc.s b/src/ldso/x86_64/tlsdesc.s
index 57b78e0b..eb21b9de 100644
--- a/src/ldso/x86_64/tlsdesc.s
+++ b/src/ldso/x86_64/tlsdesc.s
@@ -5,6 +5,8 @@ __tlsdesc_static:
mov 8(%rax),%rax
+.hidden __tls_get_new
.global __tlsdesc_dynamic
.type __tlsdesc_dynamic,@function
@@ -29,7 +31,7 @@ __tlsdesc_dynamic:
push %r10
push %r11
mov %rax,%rdi
- call __tls_get_addr
+ call __tls_get_new
pop %r11
pop %r10
pop %r9