path: root/arch
diff options
authorRich Felker <>2016-02-08 21:07:09 +0000
committerRich Felker <>2016-02-08 21:07:09 +0000
commit869a9df5b5f7da57ebd86d146e25f78450678eeb (patch)
treef103aef8f361afde0378016e1b2b6f2c069edbc8 /arch
parent756c8af8589265e99e454fe3adcda1d0bc5e1963 (diff)
remove workaround for broken mips assemblers
the workaround was for a bug that botched .gpword references to local labels, applying a nonsensical random offset of -0x4000 to them. this reverses commit 5e396fb996a80b035d0f6ecf7fed50f68aa3ebb7 and a removes a similar hack that was added to syscall_cp.s in the later commit 756c8af8589265e99e454fe3adcda1d0bc5e1963. it turns out one additional instance of the same idiom, the GETFUNCSYM macro in arch/mips/reloc.h, was still affected by the assembler bug and does not admit an easy workaround without making assumptions about how the macro is used. the previous workarounds made static linking work but left the early-stage dynamic linker broken and thus had limited usefulness. instead, affected users (using binutils versions older than 2.20) will need to fix the bug on the binutils side; the trivial patch is commit 453f5985b13e35161984bf1bf657bbab11515aa4 in the binutils-gdb repository.
Diffstat (limited to 'arch')
1 files changed, 1 insertions, 4 deletions
diff --git a/arch/mips/crt_arch.h b/arch/mips/crt_arch.h
index f4ba02ae..9fc50d7c 100644
--- a/arch/mips/crt_arch.h
+++ b/arch/mips/crt_arch.h
@@ -4,16 +4,13 @@ __asm__(
".text \n"
".global _" START "\n"
".global " START "\n"
-".global " START "_data\n"
".type _" START ", @function\n"
".type " START ", @function\n"
-".type " START "_data, @function\n"
"_" START ":\n"
"" START ":\n"
" bal 1f \n"
" move $fp, $0 \n"
-"" START "_data: \n"
-" .gpword " START "_data \n"
+" .gpword . \n"
" .gpword " START "_c \n"
".weak _DYNAMIC \n"
".hidden _DYNAMIC \n"