path: root/arch/sh/src
diff options
authorBobby Bingham <>2014-03-16 16:17:28 -0500
committerBobby Bingham <>2014-03-16 16:17:28 -0500
commit611eabd489ce4eab3a70c410f363774bbcbbd3e9 (patch)
treed98e2665a754e93077c537d9263e927a44b7aee7 /arch/sh/src
parent2b47a7aff24bbfbe7ba89fc6d542acc9f5493ae2 (diff)
superh: fix dynamic linking of __fpscr_values
Applications ended up with copy relocations for this array, which resulted in libc's references to this array pointing to the application's copy. The dynamic linker, however, can require this array before the application is relocated, and therefore before the application's copy of this array is initialized. This resulted in garbage being loaded into FPSCR before executing main, which violated the ABI. We fix this by putting the array in crt1 and making the libc copy private. This prevents libc's reference to the array from pointing to an uninitialized copy in the application.
Diffstat (limited to 'arch/sh/src')
1 files changed, 4 insertions, 1 deletions
diff --git a/arch/sh/src/__fpsrc_values.c b/arch/sh/src/__fpsrc_values.c
index 56056617..64b458f9 100644
--- a/arch/sh/src/__fpsrc_values.c
+++ b/arch/sh/src/__fpsrc_values.c
@@ -1,2 +1,5 @@
+#include "libc.h"
/* used by gcc for switching the FPU between single and double precision */
-const unsigned long __fpscr_values[2] = { 0, 0x80000 };
+const unsigned long __fpscr_values[2] ATTR_LIBC_VISIBILITY = { 0, 0x80000 };