From cbc02ba23cec16d7a821648ea8424546bc7f02dc Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Tue, 14 Apr 2015 11:18:59 -0400 Subject: consistently use hidden visibility for cancellable syscall internals in a few places, non-hidden symbols were referenced from asm in ways that assumed ld-time binding. while these is no semantic reason these symbols need to be hidden, fixing the references without making them hidden was going to be ugly, and hidden reduces some bloat anyway. in the asm files, .global/.hidden directives have been moved to the top to unclutter the actual code. --- src/thread/i386/syscall_cp.s | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'src/thread/i386/syscall_cp.s') diff --git a/src/thread/i386/syscall_cp.s b/src/thread/i386/syscall_cp.s index 71ce63f7..7dce1eb3 100644 --- a/src/thread/i386/syscall_cp.s +++ b/src/thread/i386/syscall_cp.s @@ -1,5 +1,13 @@ .text +.global __cp_begin +.hidden __cp_begin +.global __cp_end +.hidden __cp_end +.global __cp_cancel +.hidden __cp_cancel +.hidden __cancel .global __syscall_cp_asm +.hidden __syscall_cp_asm .type __syscall_cp_asm,@function __syscall_cp_asm: mov 4(%esp),%ecx @@ -7,7 +15,6 @@ __syscall_cp_asm: pushl %esi pushl %edi pushl %ebp -.global __cp_begin __cp_begin: movl (%ecx),%eax testl %eax,%eax @@ -20,14 +27,12 @@ __cp_begin: movl 44(%esp),%edi movl 48(%esp),%ebp int $128 -.global __cp_end __cp_end: popl %ebp popl %edi popl %esi popl %ebx ret -.global __cp_cancel __cp_cancel: popl %ebp popl %edi -- cgit v1.2.1