From 70b584bc9467ce939c73898212c17be1ab7e39af Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Sat, 2 Feb 2013 01:31:10 -0500 Subject: fix error returns in gethostby*_r functions they're supposed to return an error code rather than using errno. --- src/network/gethostbyname2_r.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'src/network/gethostbyname2_r.c') diff --git a/src/network/gethostbyname2_r.c b/src/network/gethostbyname2_r.c index c2ed75b4..49e4e531 100644 --- a/src/network/gethostbyname2_r.c +++ b/src/network/gethostbyname2_r.c @@ -25,10 +25,7 @@ int gethostbyname2_r(const char *name, int af, /* Align buffer */ i = (uintptr_t)buf & sizeof(char *)-1; if (i) { - if (buflen < sizeof(char *)-i) { - errno = ERANGE; - return -1; - } + if (buflen < sizeof(char *)-i) return ERANGE; buf += sizeof(char *)-i; buflen -= sizeof(char *)-i; } @@ -37,16 +34,16 @@ int gethostbyname2_r(const char *name, int af, switch (getaddrinfo(name, 0, &hint, &ai)) { case EAI_NONAME: *err = HOST_NOT_FOUND; - return -1; + return errno; case EAI_AGAIN: *err = TRY_AGAIN; - return -1; + return errno; default: case EAI_MEMORY: case EAI_SYSTEM: case EAI_FAIL: *err = NO_RECOVERY; - return -1; + return errno; case 0: break; } @@ -63,8 +60,7 @@ int gethostbyname2_r(const char *name, int af, if (need > buflen) { freeaddrinfo(ai); - errno = ERANGE; - return -1; + return ERANGE; } h->h_aliases = (void *)buf; -- cgit v1.2.1