summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorLines
2011-04-03pthread_create need not set errnoRich Felker-1/+1
2011-04-03fix statvfs syscalls (missing size argument)Rich Felker-3/+3
2011-04-03block all signals during rsyscallRich Felker-4/+9
otherwise a signal handler could see an inconsistent and nonconformant program state where different threads have different uids/gids.
2011-04-03fix race condition in rsyscall handlerRich Felker-1/+1
the problem: there is a (single-instruction) race condition window between a thread flagging itself dead and decrementing itself from the thread count. if it receives the rsyscall signal at this exact moment, the rsyscall caller will never succeed in signalling enough flags to succeed, and will deadlock forever. in previous versions of musl, the about-to-terminate thread masked all signals prior to decrementing the thread count, but this cost a whole syscall just to account for extremely rare races. the solution is a huge hack: rather than blocking in the signal handler if the thread is dead, modify the signal mask of the saved context and return in order to prevent further signal handling by the dead thread. this allows the dead thread to continue decrementing the thread count (if it had not yet done so) and exiting, even while the live part of the program blocks for rsyscall.
2011-04-03don't trust siginfo in rsyscall handlerRich Felker-3/+2
for some inexplicable reason, linux allows the sender of realtime signals to spoof its identity. permission checks for sending signals should limit the impact to same-user processes, but just to be safe, we avoid trusting the siginfo structure and instead simply examine the program state to see if we're in the middle of a legitimate rsyscall.
2011-04-03timer threads should sleep and stay asleep... a long timeRich Felker-1/+1
2011-04-03revert to deleting kernel-level timer from cancellation handlerRich Felker-7/+11
this is necessary in order to avoid breaking timer_getoverrun in the last run of the timer event handler, if it has not yet finished.
2011-04-03simplify calling of timer signal handlerRich Felker-12/+6
2011-04-03d_fileno alias for d_ino in direntRich Felker-0/+2
this is nonstandard but since POSIX reserved d_ prefix in dirent.h we might as well define it unconditionally. some programs depend on it.
2011-04-03simplify pthread tsd key handlingRich Felker-10/+7
2011-04-03omit pthread tsd dtor code if tsd is not usedRich Felker-14/+24
2011-04-02don't disable seeking after first seek failureRich Felker-8/+0
this could cause problems if the application uses dup2(fd,fileno(f)) to redirect, and the old fd was not seekable but the new fd is.
2011-04-02apparently fseek should not set the error flag on failed seekRich Felker-4/+1
2011-04-01update release notesv0.7.5Rich Felker-1/+2
2011-04-01avoid over-allocation of brk on first mallocRich Felker-4/+4
if init_malloc returns positive (successful first init), malloc will retry getting a chunk from the free bins rather than expanding the heap again. also pass init_malloc a hint for the size of the initial allocation.
2011-04-01reorganize the __libc structure for threaded performance issuesRich Felker-6/+6
we want to keep atomically updated fields (locks and thread count) and really anything writable far away from frequently-needed function pointers. stuff some rarely-needed function pointers in between to pad, hopefully up to a cache line boundary.
2011-04-01simplify setting result on thread cancellationRich Felker-1/+1
2011-04-01use bss instead of mmap for main thread's pthread thread-specific dataRich Felker-9/+4
this simplifies code and removes a failure case
2011-04-01remove obsolete and useless useconds_t typeRich Felker-7/+4
2011-04-01somehow timespec tv_nsec had the wrong type on x86_64... fixedRich Felker-1/+1
2011-04-01fix misspelled PTHREAD_CANCELED constantRich Felker-2/+2
2011-04-01document more changesRich Felker-0/+6
2011-04-01document changes for upcoming 0.7.5 releaseRich Felker-0/+19
2011-04-01use a_store to set cancel flag in pthread_cancel, to ensure a barrierRich Felker-1/+1
2011-03-31simplify pthread_key_deleteRich Felker-1/+1
calling this function on an uninitialized key value is UB, so there is no need to check that the table pointer was initialized.
2011-03-31greatly simplify pthread_key_create (~20% size reduction)Rich Felker-10/+9
2011-03-30add some missing prototypes for nonstandard functions (strsep, clearenv)Rich Felker-0/+2
2011-03-30avoid all malloc/free in timer creation/destructionRich Felker-31/+22
instead of allocating a userspace structure for signal-based timers, simply use the kernel timer id. we use the fact that thread pointers will always be zero in the low bit (actually more) to encode integer timerid values as pointers. also, this change ensures that the timer_destroy syscall has completed before the library timer_destroy function returns, in case it matters.
2011-03-30optimize timer creation and possibly protect against some minor racesRich Felker-16/+19
the major idea of this patch is not to depend on having the timer pointer delivered to the signal handler, and instead use the thread pointer to get the callback function address and argument. this way, the parent thread can make the timer_create syscall while the child thread is starting, and it should never have to block waiting for the barrier.
2011-03-30avoid crash on stupid but allowable usage of pthread_mutex_unlockRich Felker-1/+3
unlocking an unlocked mutex is not UB for robust or error-checking mutexes, so we must avoid calling __pthread_self (which might crash due to lack of thread-register initialization) until after checking that the mutex is locked.
2011-03-30rename __simple_malloc.c to lite_malloc.c - yes this affects behavior!Rich Felker-0/+0
why does this affect behavior? well, the linker seems to traverse archive files starting from its current position when resolving symbols. since calloc.c comes alphabetically (and thus in sequence in the archive file) between __simple_malloc.c and malloc.c, attempts to resolve the "malloc" symbol for use by calloc.c were pulling in the full malloc.c implementation rather than the __simple_malloc.c implementation. as of now, lite_malloc.c and malloc.c are adjacent in the archive and in the correct order, so malloc.c should never be used to resolve "malloc" unless it's already needed to resolve another symbol ("free" or "realloc").
2011-03-30streamline mutex unlock to remove a useless branch, use a_store to unlockRich Felker-2/+6
this roughly halves the cost of pthread_mutex_unlock, at least for non-robust, normal-type mutexes. the a_store change is in preparation for future support of archs which require a memory barrier or special atomic store operation, and also should prevent the possibility of the compiler misordering writes.
2011-03-30cheap special-case optimization for normal mutexesRich Felker-0/+4
cycle-level benchmark on atom cpu showed typical pthread_mutex_lock call dropping from ~120 cycles to ~90 cycles with this change. benefit may vary with compiler options and version, but this optimization is very cheap to make and should always help some.
2011-03-29reorder timer initialization so that timer_create does not depend on freeRich Felker-9/+17
this allows small programs which only create times, but never delete them, to use simple_malloc instead of the full malloc.
2011-03-29missing prototype for wcscoll (stub)Rich Felker-0/+1
2011-03-29revert mutex "optimization" that turned out to be worseRich Felker-1/+1
2011-03-29implement POSIX timersRich Felker-6/+160
this implementation is superior to the glibc/nptl implementation, in that it gives true realtime behavior. there is no risk of timer expiration events being lost due to failed thread creation or failed malloc, because the thread is created as time creation time, and reused until the timer is deleted.
2011-03-29major improvements to cancellation handlingRich Felker-8/+19
- there is no longer any risk of spoofing cancellation requests, since the cancel flag is set in pthread_cancel rather than in the signal handler. - cancellation signal is no longer unblocked when running the cancellation handlers. instead, pthread_create will cause any new threads created from a cancellation handler to unblock their own cancellation signal. - various tweaks in preparation for POSIX timer support.
2011-03-29some preliminaries for adding POSIX timersRich Felker-2/+6
2011-03-29fix tempnam name generation, and a small bug in tmpnam on retry limitRich Felker-21/+20
2011-03-29make tmpfile fail after exceeding max tries.Rich Felker-2/+6
2011-03-29fix tmpnam to generate better names, not depend on non-ISO-C symbolsRich Felker-25/+17
2011-03-29fix messed-up errno if remove fails for a non-EISDIR reasonRich Felker-2/+2
2011-03-29learned something new - remove is supposed to support directories on POSIXRich Felker-1/+3
2011-03-28revert some more spin optimizations that turned out to be pessimizationsRich Felker-4/+3
2011-03-28fix bug from syscall overhaul: extra __syscall_ret call for 0-arg syscallsRich Felker-1/+1
this mainly just caused bloat, but could corrupt errno if a 0-arg syscall ever failed.
2011-03-28fix broken spinlock due to miscompilationRich Felker-1/+1
actually this trick also seems to have made the uncontended case slower.
2011-03-28prototype for getpassRich Felker-0/+4
2011-03-28remove useless field in pthread struct (wasted a good bit of space)Rich Felker-1/+0
2011-03-28fix getc - the classic error of trying to store EOF+0-255 in a char type..Rich Felker-3/+3