diff options
| author | Rich Felker <dalias@aerifal.cx> | 2017-03-14 15:13:16 -0400 |
|---|---|---|
| committer | Rich Felker <dalias@aerifal.cx> | 2017-03-14 15:13:16 -0400 |
| commit | 3ec8b3aeb88cef8574a7b0f677ebc1801f03821d (patch) | |
| tree | 3b2532fbff7a627bf8804cb557e88f45fea7c0a9 /src/legacy/getpass.c | |
| parent | 733d1ea759119bcd0554f25034d1b4113b910900 (diff) | |
| download | musl-3ec8b3aeb88cef8574a7b0f677ebc1801f03821d.tar.gz | |
fix one-byte overflow in legacy getpass function
if the length of the input was equal to the buffer size (128), a fixed
value of zero was written one byte past the end of the static buffer.
Diffstat (limited to 'src/legacy/getpass.c')
| -rw-r--r-- | src/legacy/getpass.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/legacy/getpass.c b/src/legacy/getpass.c index 15ab9851..d51286c0 100644 --- a/src/legacy/getpass.c +++ b/src/legacy/getpass.c @@ -27,7 +27,7 @@ char *getpass(const char *prompt) l = read(fd, password, sizeof password); if (l >= 0) { - if (l > 0 && password[l-1] == '\n') l--; + if (l > 0 && password[l-1] == '\n' || l==sizeof password) l--; password[l] = 0; } |